Netdev List
 help / color / mirror / Atom feed
From: Joakim Koskela <joakim.koskela@hiit.fi>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
	Patrick McHardy <kaber@trash.net>
Subject: Re: [PATCH] netdev: Reset ipv4 flags during bundle creation on interfamily ipsec
Date: Fri, 19 Oct 2007 16:20:30 +0300	[thread overview]
Message-ID: <200710191620.31168.joakim.koskela@hiit.fi> (raw)
In-Reply-To: <20071019130905.GA14032@gondor.apana.org.au>

On Friday 19 October 2007 16:09:05 Herbert Xu wrote:
> On Fri, Oct 19, 2007 at 02:40:16PM +0300, Joakim Koskela wrote:
> >
> > This bit was chopped off the larger patch dealing with the problems
> > related to creating the bundles for inter-family tranformations.
>
> This changes behaviour.  Previously the same TOS value would be
> used all the way through.  With this it won't apply to the first
> tunnel and every SA after it.
>
> Cheers,

I'm not sure I follow. This affects the ipv6 bundling only where the struct 
(fl_tunnel) has previously been used for ipv6 addresses. Not that we are 
using the same block for holding the ipv4 info, the tos-value is really 
undefined before we reset it.

br, j

  reply	other threads:[~2007-10-19 13:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-19 11:37 [PATCH] netdev: Netfilters on outgoing interfamily ipsec Joakim Koskela
2007-10-19 11:40 ` [PATCH] netdev: Reset ipv4 flags during bundle creation on " Joakim Koskela
2007-10-19 13:09   ` Herbert Xu
2007-10-19 13:20     ` Joakim Koskela [this message]
2007-10-19 14:25       ` Herbert Xu
2007-10-22  6:55         ` Joakim Koskela
2007-10-22  8:51           ` Herbert Xu
2007-10-19 12:55 ` [PATCH] netdev: Netfilters on outgoing " Herbert Xu
2007-10-19 13:18   ` Joakim Koskela

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200710191620.31168.joakim.koskela@hiit.fi \
    --to=joakim.koskela@hiit.fi \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=kaber@trash.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox