From: Stephen Hemminger <shemminger@linux-foundation.org>
To: "Jon Nelson" <jnelson@jamponi.net>
Cc: "Jarek Poplawski" <jarkao2@o2.pl>,
"Andrew Morton" <akpm@linux-foundation.org>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, jnelson-kernel-bugzilla@jamponi.net
Subject: Re: [PATCH] via-velocity: don't oops on MTU change.
Date: Thu, 15 Nov 2007 20:05:20 -0800 [thread overview]
Message-ID: <20071115200520.0a887abb@freepuppy.rosehill> (raw)
In-Reply-To: <cccedfc60711151842l4aafe0ffo220e84a5e37b6a82@mail.gmail.com>
On Thu, 15 Nov 2007 20:42:55 -0600
"Jon Nelson" <jnelson@jamponi.net> wrote:
> On 11/15/07, Jarek Poplawski <jarkao2@o2.pl> wrote:
> ..
>
> > Sure! I was only worried velocity_open() treats dev->mtu
> > a bit different than velocity_change_mtu(), so eg. after:
> >
> > velocity_change_mtu() // dev is down
> > velocity_open()
> > velocity_change_mtu() // dev is up
> >
> > with the same mtu, vptr->rx_buf_sz could be different than after:
> >
> > velocity_open()
> > velocity_change_mtu() // dev is up
> >
> > But, probably, I miss someting.
>
> There is a snag here: if I change the MTU after the device is UP
> something ends up rather broken. A tcpdump shows nearly every outgoing
> frame has a bad TCP checksum (and the card does not support H/W
> checksumming or it is turned off as reported by ethtool).
>
That is a different (and pre-existing bug).
--
Stephen Hemminger <shemminger@linux-foundation.org>
next prev parent reply other threads:[~2007-11-16 4:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-9382-10286@http.bugzilla.kernel.org/>
2007-11-15 3:23 ` [Bugme-new] [Bug 9382] New: etting MTU > 1500 on card "cold" sigsegs the "ip" program and produces an OOPS Andrew Morton
2007-11-15 3:38 ` [PATCH] via-velocity: don't oops on MTU change Stephen Hemminger
2007-11-15 3:48 ` David Miller
2007-11-15 8:26 ` Jarek Poplawski
2007-11-15 18:20 ` Stephen Hemminger
2007-11-15 23:10 ` Jarek Poplawski
2007-11-16 2:42 ` Jon Nelson
2007-11-16 4:05 ` Stephen Hemminger [this message]
2007-11-16 4:35 ` Stephen Hemminger
2007-11-16 16:21 ` Jon Nelson
2007-11-16 16:47 ` Stephen Hemminger
2007-11-17 0:25 ` David Miller
2007-11-17 0:59 ` Jon Nelson
2007-11-17 15:04 ` Jarek Poplawski
2007-11-28 22:02 ` Jon Nelson
2007-11-28 22:20 ` [PATCH] via-velocity: don't oops on MTU change (resend) Stephen Hemminger
2007-12-01 21:36 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071115200520.0a887abb@freepuppy.rosehill \
--to=shemminger@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=jarkao2@o2.pl \
--cc=jnelson-kernel-bugzilla@jamponi.net \
--cc=jnelson@jamponi.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox