From: Stephen Hemminger <shemminger@linux-foundation.org>
To: "Jon Nelson" <jnelson@jamponi.net>
Cc: "Jarek Poplawski" <jarkao2@o2.pl>,
"Andrew Morton" <akpm@linux-foundation.org>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, jnelson-kernel-bugzilla@jamponi.net
Subject: Re: [PATCH] via-velocity: don't oops on MTU change.
Date: Fri, 16 Nov 2007 08:47:06 -0800 [thread overview]
Message-ID: <20071116084706.467aa834@freepuppy.rosehill> (raw)
In-Reply-To: <cccedfc60711160821p5f1790eaq8d385e71726cd5a0@mail.gmail.com>
On Fri, 16 Nov 2007 10:21:25 -0600
"Jon Nelson" <jnelson@jamponi.net> wrote:
> I get a segmentation fault.
>
> Should this patch be in addition to the one from bug 9382?
> http://bugzilla.kernel.org/attachment.cgi?id=13555&action=view
>
Yes. The new patch adds just recomputes the rx buf size in
one place, so it can be set when device is down.
Also, the computation will always yield same result now, the old
code computed different values depending on whether it was initial
or changed MTU.
--
Stephen Hemminger <shemminger@linux-foundation.org>
next prev parent reply other threads:[~2007-11-16 16:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-9382-10286@http.bugzilla.kernel.org/>
2007-11-15 3:23 ` [Bugme-new] [Bug 9382] New: etting MTU > 1500 on card "cold" sigsegs the "ip" program and produces an OOPS Andrew Morton
2007-11-15 3:38 ` [PATCH] via-velocity: don't oops on MTU change Stephen Hemminger
2007-11-15 3:48 ` David Miller
2007-11-15 8:26 ` Jarek Poplawski
2007-11-15 18:20 ` Stephen Hemminger
2007-11-15 23:10 ` Jarek Poplawski
2007-11-16 2:42 ` Jon Nelson
2007-11-16 4:05 ` Stephen Hemminger
2007-11-16 4:35 ` Stephen Hemminger
2007-11-16 16:21 ` Jon Nelson
2007-11-16 16:47 ` Stephen Hemminger [this message]
2007-11-17 0:25 ` David Miller
2007-11-17 0:59 ` Jon Nelson
2007-11-17 15:04 ` Jarek Poplawski
2007-11-28 22:02 ` Jon Nelson
2007-11-28 22:20 ` [PATCH] via-velocity: don't oops on MTU change (resend) Stephen Hemminger
2007-12-01 21:36 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071116084706.467aa834@freepuppy.rosehill \
--to=shemminger@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=jarkao2@o2.pl \
--cc=jnelson-kernel-bugzilla@jamponi.net \
--cc=jnelson@jamponi.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox