Netdev List
 help / color / mirror / Atom feed
* [PATCH] cassini: NAPI configuration
@ 2007-11-21 19:53 Stephen Hemminger
  2007-11-23  1:00 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2007-11-21 19:53 UTC (permalink / raw)
  To: Jeff Garzik; +Cc: netdev

The Cassini driver has NAPI support, but it not possible to configure it.
Compile tested only, no idea if it works (no hardware).
Get rid of warning from lefover variable in now visible code.

Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>

--- a/drivers/net/Kconfig	2007-11-19 18:56:12.000000000 -0800
+++ b/drivers/net/Kconfig	2007-11-21 11:28:20.000000000 -0800
@@ -587,6 +587,15 @@ config CASSINI
 	  Support for the Sun Cassini chip, aka Sun GigaSwift Ethernet. See also
 	  <http://www.sun.com/products-n-solutions/hardware/docs/pdf/817-4341-10.pdf>
 
+config CASSINI_NAPI
+	bool "Use Rx Polling (NAPI) (EXPERIMENTAL)"
+	depends on CASSINI && EXPERIMENTAL
+	help
+	  NAPI is a new driver API designed to reduce CPU and interrupt load
+	  when the driver is receiving lots of packets from the card.
+
+	  If in doubt, say N.
+
 config SUNVNET
 	tristate "Sun Virtual Network support"
 	depends on SUN_LDOMS
--- a/drivers/net/cassini.c	2007-11-16 16:17:20.000000000 -0800
+++ b/drivers/net/cassini.c	2007-11-21 11:30:43.000000000 -0800
@@ -2611,7 +2611,7 @@ static int cas_poll(struct napi_struct *
 {
 	struct cas *cp = container_of(napi, struct cas, napi);
 	struct net_device *dev = cp->dev;
-	int i, enable_intr, todo, credits;
+	int i, enable_intr, credits;
 	u32 status = readl(cp->regs + REG_INTR_STATUS);
 	unsigned long flags;
 

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] cassini: NAPI configuration
  2007-11-21 19:53 [PATCH] cassini: NAPI configuration Stephen Hemminger
@ 2007-11-23  1:00 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2007-11-23  1:00 UTC (permalink / raw)
  To: shemminger; +Cc: jgarzik, netdev

From: Stephen Hemminger <shemminger@linux-foundation.org>
Date: Wed, 21 Nov 2007 11:53:58 -0800

> The Cassini driver has NAPI support, but it not possible to configure it.
> Compile tested only, no idea if it works (no hardware).
> Get rid of warning from lefover variable in now visible code.
> 
> Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>

This driver needs massive amounts of work, and along with some
contacts within Sun I plan to make this soon after I get back
from Korea.

Therefore, please leave this stuff alone for a bit.

Thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-11-23  1:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-21 19:53 [PATCH] cassini: NAPI configuration Stephen Hemminger
2007-11-23  1:00 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox