[PATCH] correct typo in __xfrm4_bundle_create()

[PATCH] correct typo in __xfrm4_bundle_create()

[Ian Brown]

Hello,
 This is a typo correction in net/ipv4/xfrm4_policy.c; it should be
"Copy neighbour" instead "Copy neighbout",


Regards,
Ian Brown

Signed-off-by: ianbrn@gmail.com

diff --git a/a/net/ipv4/xfrm4_policy.c b/b/net/ipv4/xfrm4_policy.c
index cc86fb1..390dc7c 100644
--- a/a/net/ipv4/xfrm4_policy.c
+++ b/b/net/ipv4/xfrm4_policy.c
@@ -165,7 +165,7 @@ __xfrm4_bundle_create(struct xfrm_policy *policy,
struct xfrm_state **xfrm, int
 		dst_prev->trailer_len	= trailer_len;
 		memcpy(&dst_prev->metrics, &x->route->metrics, sizeof(dst_prev->metrics));

-		/* Copy neighbout for reachability confirmation */
+		/* Copy neighbour for reachability confirmation */
 		dst_prev->neighbour	= neigh_clone(rt->u.dst.neighbour);
 		dst_prev->input		= rt->u.dst.input;
 		dst_prev->output = dst_prev->xfrm->outer_mode->afinfo->output;

Re: [PATCH] correct typo in __xfrm4_bundle_create()

[David Miller]

From: "Ian Brown" <ianbrn@gmail.com>
Date: Wed, 5 Dec 2007 12:49:52 +0200

>  This is a typo correction in net/ipv4/xfrm4_policy.c; it should be
> "Copy neighbour" instead "Copy neighbout",

Your email client has corrupted the patch by adding
newlines among other things.

This happens often for gmail users, because by default
gmail does text formatting which you don't want it
to do for patches because it corrupts them.

Please use an attachment or some other method to prevent
this form happening so that you patch is not corrupted.

Re: [PATCH] correct typo in __xfrm4_bundle_create()

[Ian Brown]

[-- Attachment #1: Type: text/plain, Size: 856 bytes --]

Hello,
Sorry; I was not aware of it; I am sending here  the patch as an attachment.
It is a typo correction in __xfrm4_bundle_create() in net/ipv4/xfrm4_policy.c;
 it should be "Copy neighbour" instead "Copy neighbout"
Ian


On Dec 5, 2007 3:20 PM, David Miller <davem@davemloft.net> wrote:
> From: "Ian Brown" <ianbrn@gmail.com>
> Date: Wed, 5 Dec 2007 12:49:52 +0200
>
> >  This is a typo correction in net/ipv4/xfrm4_policy.c; it should be
> > "Copy neighbour" instead "Copy neighbout",
>
> Your email client has corrupted the patch by adding
> newlines among other things.
>
> This happens often for gmail users, because by default
> gmail does text formatting which you don't want it
> to do for patches because it corrupts them.
>
> Please use an attachment or some other method to prevent
> this form happening so that you patch is not corrupted.
>

[-- Attachment #2: patchToNetDev.txt --]
[-- Type: text/plain, Size: 690 bytes --]

Signed-off-by: ianbrn@gmail.com

diff --git a/a/net/ipv4/xfrm4_policy.c b/b/net/ipv4/xfrm4_policy.c
index cc86fb1..390dc7c 100644
--- a/a/net/ipv4/xfrm4_policy.c
+++ b/b/net/ipv4/xfrm4_policy.c
@@ -165,7 +165,7 @@ __xfrm4_bundle_create(struct xfrm_policy *policy, struct xfrm_state **xfrm, int
 		dst_prev->trailer_len	= trailer_len;
 		memcpy(&dst_prev->metrics, &x->route->metrics, sizeof(dst_prev->metrics));
 
-		/* Copy neighbout for reachability confirmation */
+		/* Copy neighbour for reachability confirmation */
 		dst_prev->neighbour	= neigh_clone(rt->u.dst.neighbour);
 		dst_prev->input		= rt->u.dst.input;
 		dst_prev->output = dst_prev->xfrm->outer_mode->afinfo->output;
		

Re: [PATCH] correct typo in __xfrm4_bundle_create()

[David Miller]

From: "Ian Brown" <ianbrn@gmail.com>
Date: Wed, 5 Dec 2007 15:41:37 +0200

> Hello,
> Sorry; I was not aware of it; I am sending here  the patch as an attachment.
> It is a typo correction in __xfrm4_bundle_create() in net/ipv4/xfrm4_policy.c;
>  it should be "Copy neighbour" instead "Copy neighbout"

__xfrm4_bundle_create() no longer exists in the networking
development tree:

	kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6.25.git

Because Herbert Xu unified much of the IPSEC handling
paths over the past few weeks.

Re: [PATCH] correct typo in __xfrm4_bundle_create()

[Ian Brown]

Hello,
Sorry ; but is this tree can be fetched ? it requires a password.

I try:
git-clone kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6.25.git net-2.6.25
and get:
root@kernel.org's password:

Ian

On Dec 5, 2007 3:47 PM, David Miller <davem@davemloft.net> wrote:
> From: "Ian Brown" <ianbrn@gmail.com>
> Date: Wed, 5 Dec 2007 15:41:37 +0200
>
> > Hello,
> > Sorry; I was not aware of it; I am sending here  the patch as an attachment.
> > It is a typo correction in __xfrm4_bundle_create() in net/ipv4/xfrm4_policy.c;
> >  it should be "Copy neighbour" instead "Copy neighbout"
>
> __xfrm4_bundle_create() no longer exists in the networking
> development tree:
>
>         kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6.25.git
>
> Because Herbert Xu unified much of the IPSEC handling
> paths over the past few weeks.
>

Re: [PATCH] correct typo in __xfrm4_bundle_create()

[David Miller]

From: "Ian Brown" <ianbrn@gmail.com>
Date: Wed, 5 Dec 2007 15:59:52 +0200

> Hello,
> Sorry ; but is this tree can be fetched ? it requires a password.
> 
> I try:
> git-clone kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6.25.git net-2.6.25
> and get:
> root@kernel.org's password:

Use the git:// URL prefix.

Re: [PATCH] correct typo in __xfrm4_bundle_create()

[Ian Brown]

Hello,
Sorry, but I had tried several times from 3 machines (without
iptables/SELinux)  and git-clone
gives "Connection refused" error.

git-clone git://kernel.org/pub/scm/linux/kernel/git/davem/net-2.6.25.git 2.6.25

Initialized empty Git repository in /work/src/2.6.25/.git/
fatal: unable to connect a socket (Connection refused)
fetch-pack from
'git://kernel.org/pub/scm/linux/kernel/git/davem/net-2.6.25.git'
failed.
Ian


On Dec 5, 2007 4:03 PM, David Miller <davem@davemloft.net> wrote:
> From: "Ian Brown" <ianbrn@gmail.com>
> Date: Wed, 5 Dec 2007 15:59:52 +0200
>
> > Hello,
> > Sorry ; but is this tree can be fetched ? it requires a password.
> >
> > I try:
> > git-clone kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6.25.git net-2.6.25
> > and get:
> > root@kernel.org's password:
>
> Use the git:// URL prefix.
>

Re: [PATCH] correct typo in __xfrm4_bundle_create()

[David Miller]

From: "Ian Brown" <ianbrn@gmail.com>
Date: Wed, 5 Dec 2007 16:33:56 +0200

> Hello,
> Sorry, but I had tried several times from 3 machines (without
> iptables/SELinux)  and git-clone
> gives "Connection refused" error.
> 
> git-clone git://kernel.org/pub/scm/linux/kernel/git/davem/net-2.6.25.git 2.6.25

git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6.25.git

I just publish my URL's in the:

	kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6.git

canonical form so that they are easy to edit into:

	master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6.git

for SSH users and into:

	git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6.25.git

for non-SSH users.