* [PATCH] iproute2: off by one in nested attribute parse
@ 2007-12-10 19:38 Stephen Hemminger
0 siblings, 0 replies; only message in thread
From: Stephen Hemminger @ 2007-12-10 19:38 UTC (permalink / raw)
To: Patrick McHardy; +Cc: netdev
Fix off by one in nested attribute management.
Fixes segv in:
tc qdisc show dev eth1
due to uninitialized attribute table.
Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
---
lib/libnetlink.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lib/libnetlink.c b/lib/libnetlink.c
index 12883fe..d13596f 100644
--- a/lib/libnetlink.c
+++ b/lib/libnetlink.c
@@ -632,6 +632,6 @@ int __parse_rtattr_nested_compat(struct rtattr *tb[], int max, struct rtattr *rt
rta = RTA_DATA(rta) + RTA_ALIGN(len);
return parse_rtattr_nested(tb, max, rta);
}
- memset(tb, 0, sizeof(struct rtattr *) * max);
+ memset(tb, 0, sizeof(struct rtattr *) * (max + 1));
return 0;
}
--
1.5.3.4
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2007-12-10 19:39 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-12-10 19:38 [PATCH] iproute2: off by one in nested attribute parse Stephen Hemminger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox