From: Stephen Hemminger <shemminger@linux-foundation.org>
To: "Joonwoo Park" <joonwpark81@gmail.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<jgarzik@pobox.com>, <baum@tehutinetworks.net>,
<andy@greyhouse.net>
Subject: Re: [PATCH 6/7] : tehuti Fix possible causing oops of net_rx_action
Date: Tue, 11 Dec 2007 21:39:39 -0800 [thread overview]
Message-ID: <20071211213939.122de1db@freepuppy.rosehill> (raw)
In-Reply-To: <002901c83c73$b089b6e0$9c94fea9@jason>
On Wed, 12 Dec 2007 13:01:27 +0900
"Joonwoo Park" <joonwpark81@gmail.com> wrote:
> [NETDEV]: tehuti Fix possible causing oops of net_rx_action
>
> Signed-off-by: Joonwoo Park <joonwpark81@gmail.com>
> ---
> drivers/net/tehuti.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/tehuti.c b/drivers/net/tehuti.c
> index 21230c9..955e749 100644
> --- a/drivers/net/tehuti.c
> +++ b/drivers/net/tehuti.c
> @@ -305,6 +305,8 @@ static int bdx_poll(struct napi_struct *napi, int budget)
>
> netif_rx_complete(dev, napi);
> bdx_enable_interrupts(priv);
> + if (unlikely(work_done == napi->weight))
> + return work_done - 1;
> }
> return work_done;
> }
A better fix would be not going over budget in the first place.
--
Stephen Hemminger <shemminger@linux-foundation.org>
next prev parent reply other threads:[~2007-12-12 5:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-12 4:01 [PATCH 6/7] : tehuti Fix possible causing oops of net_rx_action Joonwoo Park
2007-12-12 5:39 ` Stephen Hemminger [this message]
2007-12-12 5:46 ` [RFC] net: napi fix Stephen Hemminger
2007-12-12 6:05 ` Joonwoo Park
2007-12-12 15:22 ` David Miller
2007-12-12 15:21 ` David Miller
2007-12-12 5:48 ` [PATCH 6/7] : tehuti Fix possible causing oops of net_rx_action Joonwoo Park
2007-12-12 5:53 ` Stephen Hemminger
2007-12-12 15:20 ` [PATCH 6/7] [NETDEV]: " David Miller
2007-12-12 16:36 ` Stephen Hemminger
2007-12-12 15:18 ` [PATCH 6/7] : " David Miller
2007-12-12 21:58 ` [RFT] tehuti: napi fix Stephen Hemminger
2007-12-16 21:38 ` David Miller
2007-12-17 20:18 ` Stephen Hemminger
2007-12-13 7:07 ` [PATCH 6/7] : tehuti Fix possible causing oops of net_rx_action Joonwoo Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071211213939.122de1db@freepuppy.rosehill \
--to=shemminger@linux-foundation.org \
--cc=andy@greyhouse.net \
--cc=baum@tehutinetworks.net \
--cc=jgarzik@pobox.com \
--cc=joonwpark81@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox