* [PATCH 1/2] tulip: napi full quantum bug
[not found] ` <1dd3c7c0712080344q414fe7c3w32d7ca6d900a52b5@mail.gmail.com>
@ 2007-12-13 17:35 ` Stephen Hemminger
2007-12-16 21:40 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2007-12-13 17:35 UTC (permalink / raw)
To: kristjan, David S. Miller, Jeff Garzik; +Cc: netdev
This should fix the kernel warn/oops reported while routing.
The tulip driver has a fencepost bug with new NAPI in 2.6.24
It has an off by one bug if a full quantum is reached.
Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
--- a/drivers/net/tulip/interrupt.c 2007-12-13 09:20:27.000000000 -0800
+++ b/drivers/net/tulip/interrupt.c 2007-12-13 09:23:34.000000000 -0800
@@ -151,7 +151,8 @@ int tulip_poll(struct napi_struct *napi,
if (tulip_debug > 5)
printk(KERN_DEBUG "%s: In tulip_rx(), entry %d %8.8x.\n",
dev->name, entry, status);
- if (work_done++ >= budget)
+
+ if (++work_done >= budget)
goto not_done;
if ((status & 0x38008300) != 0x0300) {
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 1/2] tulip: napi full quantum bug
2007-12-13 17:35 ` [PATCH 1/2] tulip: napi full quantum bug Stephen Hemminger
@ 2007-12-16 21:40 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2007-12-16 21:40 UTC (permalink / raw)
To: shemminger; +Cc: kristjan.ugrin, jgarzik, netdev
From: Stephen Hemminger <shemminger@linux-foundation.org>
Date: Thu, 13 Dec 2007 09:35:45 -0800
> This should fix the kernel warn/oops reported while routing.
>
> The tulip driver has a fencepost bug with new NAPI in 2.6.24
> It has an off by one bug if a full quantum is reached.
>
> Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
Acked-by: David S. Miller <davem@davemloft.net>
Jeff, please apply if you haven't already.
> --- a/drivers/net/tulip/interrupt.c 2007-12-13 09:20:27.000000000 -0800
> +++ b/drivers/net/tulip/interrupt.c 2007-12-13 09:23:34.000000000 -0800
> @@ -151,7 +151,8 @@ int tulip_poll(struct napi_struct *napi,
> if (tulip_debug > 5)
> printk(KERN_DEBUG "%s: In tulip_rx(), entry %d %8.8x.\n",
> dev->name, entry, status);
> - if (work_done++ >= budget)
> +
> + if (++work_done >= budget)
> goto not_done;
>
> if ((status & 0x38008300) != 0x0300) {
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-12-16 21:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1dd3c7c0711291113v5c197561m3121afc8f676db5f@mail.gmail.com>
[not found] ` <20071129133622.56301c9d@freepuppy.rosehill>
[not found] ` <1dd3c7c0711291430r1086a46ajc4af199903a7a65e@mail.gmail.com>
[not found] ` <20071207161435.42ae67f8@freepuppy.rosehill>
[not found] ` <1dd3c7c0712080344q414fe7c3w32d7ca6d900a52b5@mail.gmail.com>
2007-12-13 17:35 ` [PATCH 1/2] tulip: napi full quantum bug Stephen Hemminger
2007-12-16 21:40 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox