Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: markryde@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] remove not used code: target hw address (tha) definition and assignment in arp_process().
Date: Wed, 19 Dec 2007 23:39:32 -0800 (PST)	[thread overview]
Message-ID: <20071219.233932.210886166.davem@davemloft.net> (raw)
In-Reply-To: <dac45060712192329v48bcd3td4f16f83ea13ba9e@mail.gmail.com>

From: "Mark Ryden" <markryde@gmail.com>
Date: Thu, 20 Dec 2007 09:29:47 +0200

>   In arp_process() (net/ipv4/arp.c), there is unused code: definition
> and assignment of tha (target hw address ).

Patch applied, thanks.

> Signed-off-by:
> markryde@gmail.com

Please format your signed off line correctly, it should
have read like the following, all on one single line:

Signed-off-by: Mark Ryden <markryde@gmail.com>

Also, your patch was not rooted properly:

--- a/a/net/ipv4/arp.c
+++ b/b/net/ipv4/arp.c

This should have been:

--- a/net/ipv4/arp.c
+++ b/net/ipv4/arp.c

Please correct these issues for future patch submissions.

Thanks.

      reply	other threads:[~2007-12-20  7:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-20  7:29 [PATCH] remove not used code: target hw address (tha) definition and assignment in arp_process() Mark Ryden
2007-12-20  7:39 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071219.233932.210886166.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=markryde@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox