From: "Mark Ryden" <markryde@gmail.com>
To: davem@davemloft.net, netdev@vger.kernel.org
Subject: [PATCH] remove not used code: target hw address (tha) definition and assignment in arp_process().
Date: Thu, 20 Dec 2007 09:29:47 +0200 [thread overview]
Message-ID: <dac45060712192329v48bcd3td4f16f83ea13ba9e@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 157 bytes --]
Hello,
In arp_process() (net/ipv4/arp.c), there is unused code: definition
and assignment of tha (target hw address ).
Signed-off-by:
markryde@gmail.com
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: patchGit.diff --]
[-- Type: text/x-patch; name=patchGit.diff, Size: 585 bytes --]
diff --git a/a/net/ipv4/arp.c b/b/net/ipv4/arp.c
index 14dec92..6f26cfe 100644
--- a/a/net/ipv4/arp.c
+++ b/b/net/ipv4/arp.c
@@ -706,7 +706,7 @@ static int arp_process(struct sk_buff *skb)
struct arphdr *arp;
unsigned char *arp_ptr;
struct rtable *rt;
- unsigned char *sha, *tha;
+ unsigned char *sha;
__be32 sip, tip;
u16 dev_type = dev->type;
int addr_type;
@@ -771,7 +771,6 @@ static int arp_process(struct sk_buff *skb)
arp_ptr += dev->addr_len;
memcpy(&sip, arp_ptr, 4);
arp_ptr += 4;
- tha = arp_ptr;
arp_ptr += dev->addr_len;
memcpy(&tip, arp_ptr, 4);
/*
next reply other threads:[~2007-12-20 7:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-20 7:29 Mark Ryden [this message]
2007-12-20 7:39 ` [PATCH] remove not used code: target hw address (tha) definition and assignment in arp_process() David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dac45060712192329v48bcd3td4f16f83ea13ba9e@mail.gmail.com \
--to=markryde@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox