[PATCH] remove not used code: target hw address (tha) definition and assignment in arp_process().

[PATCH] remove not used code: target hw address (tha) definition and assignment in arp_process().

[Mark Ryden]

[-- Attachment #1: Type: text/plain, Size: 157 bytes --]

Hello,
  In arp_process() (net/ipv4/arp.c), there is unused code: definition
and assignment of tha (target hw address ).


Signed-off-by:
markryde@gmail.com

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: patchGit.diff --]
[-- Type: text/x-patch; name=patchGit.diff, Size: 585 bytes --]

diff --git a/a/net/ipv4/arp.c b/b/net/ipv4/arp.c
index 14dec92..6f26cfe 100644
--- a/a/net/ipv4/arp.c
+++ b/b/net/ipv4/arp.c
@@ -706,7 +706,7 @@ static int arp_process(struct sk_buff *skb)
 	struct arphdr *arp;
 	unsigned char *arp_ptr;
 	struct rtable *rt;
-	unsigned char *sha, *tha;
+	unsigned char *sha;
 	__be32 sip, tip;
 	u16 dev_type = dev->type;
 	int addr_type;
@@ -771,7 +771,6 @@ static int arp_process(struct sk_buff *skb)
 	arp_ptr += dev->addr_len;
 	memcpy(&sip, arp_ptr, 4);
 	arp_ptr += 4;
-	tha	= arp_ptr;
 	arp_ptr += dev->addr_len;
 	memcpy(&tip, arp_ptr, 4);
 /*

Re: [PATCH] remove not used code: target hw address (tha) definition and assignment in arp_process().

[David Miller]

From: "Mark Ryden" <markryde@gmail.com>
Date: Thu, 20 Dec 2007 09:29:47 +0200

>   In arp_process() (net/ipv4/arp.c), there is unused code: definition
> and assignment of tha (target hw address ).

Patch applied, thanks.

> Signed-off-by:
> markryde@gmail.com

Please format your signed off line correctly, it should
have read like the following, all on one single line:

Signed-off-by: Mark Ryden <markryde@gmail.com>

Also, your patch was not rooted properly:

--- a/a/net/ipv4/arp.c
+++ b/b/net/ipv4/arp.c

This should have been:

--- a/net/ipv4/arp.c
+++ b/net/ipv4/arp.c

Please correct these issues for future patch submissions.

Thanks.