* [IPSEC]: Return EOVERFLOW when output sequence number overflows
@ 2008-01-02 7:16 Herbert Xu
2008-01-02 7:53 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Herbert Xu @ 2008-01-02 7:16 UTC (permalink / raw)
To: David S. Miller, netdev
Hi Dave:
[IPSEC]: Return EOVERFLOW when output sequence number overflows
Previously we made it an error on the output path if the sequence number
overflowed. However we did not set the err variable accordingly. This
patch sets err to -EOVERFLOW in that case.
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
diff --git a/net/xfrm/xfrm_output.c b/net/xfrm/xfrm_output.c
index 81ad8eb..f4a1047 100644
--- a/net/xfrm/xfrm_output.c
+++ b/net/xfrm/xfrm_output.c
@@ -66,6 +66,7 @@ static int xfrm_output_one(struct sk_buff *skb, int err)
if (unlikely(x->replay.oseq == 0)) {
x->replay.oseq--;
xfrm_audit_state_replay_overflow(x, skb);
+ err = -EOVERFLOW;
goto error;
}
if (xfrm_aevent_is_on())
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [IPSEC]: Return EOVERFLOW when output sequence number overflows
2008-01-02 7:16 [IPSEC]: Return EOVERFLOW when output sequence number overflows Herbert Xu
@ 2008-01-02 7:53 ` David Miller
2008-01-02 8:25 ` Herbert Xu
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2008-01-02 7:53 UTC (permalink / raw)
To: herbert; +Cc: netdev
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Wed, 2 Jan 2008 18:16:20 +1100
> [IPSEC]: Return EOVERFLOW when output sequence number overflows
>
> Previously we made it an error on the output path if the sequence number
> overflowed. However we did not set the err variable accordingly. This
> patch sets err to -EOVERFLOW in that case.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Applied.
It seems this was a regression added by Paul's patch in net-2.6.25 and
not something that needs fixing in 2.6.24 and stable?
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-01-02 8:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-01-02 7:16 [IPSEC]: Return EOVERFLOW when output sequence number overflows Herbert Xu
2008-01-02 7:53 ` David Miller
2008-01-02 8:25 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox