[PATCH net-2.6.25] [NET]: Remove obsolete comment

[PATCH net-2.6.25] [NET]: Remove obsolete comment

[Ilpo Järvinen]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1017 bytes --]

[PATCH] [NET]: Remove obsolete comment

It seems that ip_build_xmit is no longer used in here and
ip_append_data is used.

Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
---

Hi Dave,

While reading some nearby code, I noticed this. I'm not 100%
sure if the removal is valid or not nor have interest to dig
it up from history but I suppose you know it better without
having to look it up from history :-).

 net/ipv4/ip_output.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/net/ipv4/ip_output.c b/net/ipv4/ip_output.c
index 3dc0c12..e57de0f 100644
--- a/net/ipv4/ip_output.c
+++ b/net/ipv4/ip_output.c
@@ -1339,8 +1339,6 @@ static int ip_reply_glue_bits(void *dptr, char *to, int offset,
  *
  *	Should run single threaded per socket because it uses the sock
  *     	structure to pass arguments.
- *
- *	LATER: switch from ip_build_xmit to ip_append_*
  */
 void ip_send_reply(struct sock *sk, struct sk_buff *skb, struct ip_reply_arg *arg,
 		   unsigned int len)
-- 
1.5.0.6

Re: [PATCH net-2.6.25] [NET]: Remove obsolete comment

[David Miller]

From: "Ilpo_Järvinen" <ilpo.jarvinen@helsinki.fi>
Date: Sat, 5 Jan 2008 14:21:48 +0200 (EET)

> [PATCH] [NET]: Remove obsolete comment
> 
> It seems that ip_build_xmit is no longer used in here and
> ip_append_data is used.
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
> ---
> 
> Hi Dave,
> 
> While reading some nearby code, I noticed this. I'm not 100%
> sure if the removal is valid or not nor have interest to dig
> it up from history but I suppose you know it better without
> having to look it up from history :-).

It's definitely obsolete cruft, good catch, applied :-)