* [patch 1/2] hamradio: fix dmascc section mismatch
@ 2008-02-05 7:45 akpm
2008-02-05 11:04 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: akpm @ 2008-02-05 7:45 UTC (permalink / raw)
To: davem; +Cc: netdev, akpm, randy.dunlap, klaus.kudielka, sam
From: Randy Dunlap <randy.dunlap@oracle.com>
hw[] is used in both init and exit functions so it cannot be initdata (section
mismatch is when CONFIG_MODULES=n and CONFIG_DMASCC=y).
WARNING: vmlinux.o(.exit.text+0xba7): Section mismatch: reference to .init.data: (between 'dmascc_exit' and 'sixpack_exit_driver')
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Klaus Kudielka <klaus.kudielka@gmx.net>
Cc: Sam Ravnborg <sam@ravnborg.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
drivers/net/hamradio/dmascc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff -puN drivers/net/hamradio/dmascc.c~hamradio-fix-dmascc-section-mismatch drivers/net/hamradio/dmascc.c
--- a/drivers/net/hamradio/dmascc.c~hamradio-fix-dmascc-section-mismatch
+++ a/drivers/net/hamradio/dmascc.c
@@ -262,8 +262,8 @@ static void tm_isr(struct scc_priv *priv
static int io[MAX_NUM_DEVS] __initdata = { 0, };
-/* Beware! hw[] is also used in cleanup_module(). */
-static struct scc_hardware hw[NUM_TYPES] __initdata_or_module = HARDWARE;
+/* Beware! hw[] is also used in dmascc_exit(). */
+static struct scc_hardware hw[NUM_TYPES] = HARDWARE;
/* Global variables */
_
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [patch 1/2] hamradio: fix dmascc section mismatch
2008-02-05 7:45 [patch 1/2] hamradio: fix dmascc section mismatch akpm
@ 2008-02-05 11:04 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2008-02-05 11:04 UTC (permalink / raw)
To: akpm; +Cc: netdev, randy.dunlap, klaus.kudielka, sam
From: akpm@linux-foundation.org
Date: Mon, 04 Feb 2008 23:45:20 -0800
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> hw[] is used in both init and exit functions so it cannot be initdata (section
> mismatch is when CONFIG_MODULES=n and CONFIG_DMASCC=y).
>
> WARNING: vmlinux.o(.exit.text+0xba7): Section mismatch: reference to .init.data: (between 'dmascc_exit' and 'sixpack_exit_driver')
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> Cc: Klaus Kudielka <klaus.kudielka@gmx.net>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-02-05 11:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-05 7:45 [patch 1/2] hamradio: fix dmascc section mismatch akpm
2008-02-05 11:04 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox