* [RTNL]: Add missing link netlink attribute policy definitions
@ 2008-02-19 23:46 Thomas Graf
2008-02-20 0:12 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Graf @ 2008-02-19 23:46 UTC (permalink / raw)
To: davem; +Cc: netdev
IFLA_LINK is no longer a write-only attribute on the kernel
side and must thus be validated. Same goes for the newly
introduced IFLA_LINKINFO.
Fixes undefined behaviour if either of the attributes are
not well formed.
Signed-off-by: Thomas Graf <tgraf@suug.ch>
Index: net-2.6.26/net/core/rtnetlink.c
===================================================================
--- net-2.6.26.orig/net/core/rtnetlink.c 2008-02-19 20:30:08.000000000 +0100
+++ net-2.6.26/net/core/rtnetlink.c 2008-02-20 00:39:54.000000000 +0100
@@ -693,10 +693,12 @@
[IFLA_BROADCAST] = { .type = NLA_BINARY, .len = MAX_ADDR_LEN },
[IFLA_MAP] = { .len = sizeof(struct rtnl_link_ifmap) },
[IFLA_MTU] = { .type = NLA_U32 },
+ [IFLA_LINK] = { .type = NLA_U32 },
[IFLA_TXQLEN] = { .type = NLA_U32 },
[IFLA_WEIGHT] = { .type = NLA_U32 },
[IFLA_OPERSTATE] = { .type = NLA_U8 },
[IFLA_LINKMODE] = { .type = NLA_U8 },
+ [IFLA_LINKINFO] = { .type = NLA_NESTED },
[IFLA_NET_NS_PID] = { .type = NLA_U32 },
};
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-02-20 0:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-19 23:46 [RTNL]: Add missing link netlink attribute policy definitions Thomas Graf
2008-02-20 0:12 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox