* [PATCH] bridge: use time_before() in br_fdb_cleanup()
@ 2008-03-18 16:32 Stephen Hemminger
2008-03-20 22:55 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2008-03-18 16:32 UTC (permalink / raw)
To: David S. Miller; +Cc: netdev
In br_fdb_cleanup() next_timer and this_timer are in jiffies, so they
should be compared using the time_after() macro.
Signed-off-by: Fabio Checconi <fabio@gandalf.sssup.it>
Signed-off-by: Stephen Hemminger <stephen.hemminger@vyatta.com>
---
net/bridge/br_fdb.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/bridge/br_fdb.c b/net/bridge/br_fdb.c
index bc40377..9326c37 100644
--- a/net/bridge/br_fdb.c
+++ b/net/bridge/br_fdb.c
@@ -136,7 +136,7 @@ void br_fdb_cleanup(unsigned long _data)
this_timer = f->ageing_timer + delay;
if (time_before_eq(this_timer, jiffies))
fdb_delete(f);
- else if (this_timer < next_timer)
+ else if (time_before(this_timer, next_timer))
next_timer = this_timer;
}
}
--
1.5.4.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] bridge: use time_before() in br_fdb_cleanup()
2008-03-18 16:32 [PATCH] bridge: use time_before() in br_fdb_cleanup() Stephen Hemminger
@ 2008-03-20 22:55 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2008-03-20 22:55 UTC (permalink / raw)
To: shemminger; +Cc: netdev
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Tue, 18 Mar 2008 09:32:29 -0700
> In br_fdb_cleanup() next_timer and this_timer are in jiffies, so they
> should be compared using the time_after() macro.
>
> Signed-off-by: Fabio Checconi <fabio@gandalf.sssup.it>
> Signed-off-by: Stephen Hemminger <stephen.hemminger@vyatta.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-03-20 22:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-03-18 16:32 [PATCH] bridge: use time_before() in br_fdb_cleanup() Stephen Hemminger
2008-03-20 22:55 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox