From: Herbert Xu <herbert@gondor.apana.org.au>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: bridge: Eliminate unnecessary forward delay
Date: Tue, 5 Aug 2008 10:12:40 +0800 [thread overview]
Message-ID: <20080805021240.GA18159@gondor.apana.org.au> (raw)
In-Reply-To: <20080804103534.6b7896d9@extreme>
On Mon, Aug 04, 2008 at 10:35:34AM -0700, Stephen Hemminger wrote:
>
> Same again, this time compile tested...
>
> --- a/net/bridge/br_stp.c 2008-08-04 10:20:21.000000000 -0700
> +++ b/net/bridge/br_stp.c 2008-08-04 10:29:26.000000000 -0700
> @@ -368,14 +368,25 @@ static void br_make_blocking(struct net_
> /* called under bridge lock */
> static void br_make_forwarding(struct net_bridge_port *p)
> {
> - if (p->state == BR_STATE_BLOCKING) {
Is it safe to remove this check, especially if the forward delay
is non-zero?
Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2008-08-05 2:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-04 17:04 bridge: Eliminate unnecessary forward delay Herbert Xu
2008-08-04 17:27 ` Stephen Hemminger
2008-08-04 17:32 ` Herbert Xu
2008-08-04 17:35 ` Stephen Hemminger
2008-08-05 2:12 ` Herbert Xu [this message]
2008-08-05 8:40 ` David Miller
2008-08-05 8:55 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080805021240.GA18159@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox