From: Octavian Purdila <opurdila@ixiacom.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: David Miller <davem@davemloft.net>,
shemminger@vyatta.com, netdev@vger.kernel.org
Subject: Re: [RFC] [PATCH] ip: skip IP checksum for skbs with CHECKSUM_UNNECESSARY set
Date: Sat, 23 Aug 2008 12:58:11 +0300 [thread overview]
Message-ID: <200808231258.12397.opurdila@ixiacom.com> (raw)
In-Reply-To: <E1KWlT3-0001HJ-00@gondolin.me.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Sat, 23 Aug 2008 15:15:17 +1000
> > I don't think they want this for performance, they want to not have to
> > compute the IP header checksum in their HW LRO implementation, which
> > is just as silly :-)
Yes, this was the intention, it seemed like a reasonable trade-off between FPGA
space & complexity / software complexity at the time. Thanks for the input,
will do it in hardware then.
> I sure hope they're not planning on leaving out the IP header
> checksum verification too :)
Of course not :)
tavi
next prev parent reply other threads:[~2008-08-23 10:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-22 19:24 [RFC] [PATCH] ip: skip IP checksum for skbs with CHECKSUM_UNNECESSARY set Octavian Purdila
2008-08-22 22:33 ` Stephen Hemminger
2008-08-23 0:36 ` David Miller
2008-08-23 1:59 ` Stephen Hemminger
2008-08-23 5:15 ` Herbert Xu
2008-08-23 9:58 ` Octavian Purdila [this message]
2008-08-22 22:53 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200808231258.12397.opurdila@ixiacom.com \
--to=opurdila@ixiacom.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox