* [PATCH] mark flow_cache_cpu_prepare() as __init
@ 2008-11-07 3:40 Alexey Dobriyan
2008-11-07 7:07 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Alexey Dobriyan @ 2008-11-07 3:40 UTC (permalink / raw)
To: davem; +Cc: netdev
It's called from __init code only. And__devinit in generic networking code
is pretty strange :^)
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---
net/core/flow.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/net/core/flow.c
+++ b/net/core/flow.c
@@ -307,7 +307,7 @@ void flow_cache_flush(void)
put_online_cpus();
}
-static void __devinit flow_cache_cpu_prepare(int cpu)
+static void __init flow_cache_cpu_prepare(int cpu)
{
struct tasklet_struct *tasklet;
unsigned long order;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] mark flow_cache_cpu_prepare() as __init
2008-11-07 3:40 [PATCH] mark flow_cache_cpu_prepare() as __init Alexey Dobriyan
@ 2008-11-07 7:07 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2008-11-07 7:07 UTC (permalink / raw)
To: adobriyan; +Cc: netdev
From: Alexey Dobriyan <adobriyan@gmail.com>
Date: Fri, 7 Nov 2008 06:40:59 +0300
> It's called from __init code only. And__devinit in generic networking code
> is pretty strange :^)
>
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
I believe the history of this is that we used to call this thing
as a CPU hotplug operation, and at the time that was the appropriate
marker to use for such things.
Applied to net-next-2.6, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-11-07 7:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-07 3:40 [PATCH] mark flow_cache_cpu_prepare() as __init Alexey Dobriyan
2008-11-07 7:07 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox