* [PATCH] net: remove struct neigh_table::pde
@ 2008-11-11 12:07 Alexey Dobriyan
2008-11-12 1:24 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Alexey Dobriyan @ 2008-11-11 12:07 UTC (permalink / raw)
To: davem; +Cc: netdev
->pde isn't actually needed, since name is stashed in ->id.
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---
include/net/neighbour.h | 3 ---
net/core/neighbour.c | 5 ++---
2 files changed, 2 insertions(+), 6 deletions(-)
--- a/include/net/neighbour.h
+++ b/include/net/neighbour.h
@@ -180,9 +180,6 @@ struct neigh_table
__u32 hash_rnd;
unsigned int hash_chain_gc;
struct pneigh_entry **phash_buckets;
-#ifdef CONFIG_PROC_FS
- struct proc_dir_entry *pde;
-#endif
};
/* flags for neigh_update() */
--- a/net/core/neighbour.c
+++ b/net/core/neighbour.c
@@ -1424,9 +1424,8 @@ void neigh_table_init_no_netlink(struct neigh_table *tbl)
panic("cannot create neighbour cache statistics");
#ifdef CONFIG_PROC_FS
- tbl->pde = proc_create_data(tbl->id, 0, init_net.proc_net_stat,
- &neigh_stat_seq_fops, tbl);
- if (!tbl->pde)
+ if (!proc_create_data(tbl->id, 0, init_net.proc_net_stat,
+ &neigh_stat_seq_fops, tbl))
panic("cannot create neighbour proc dir entry");
#endif
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] net: remove struct neigh_table::pde
2008-11-11 12:07 [PATCH] net: remove struct neigh_table::pde Alexey Dobriyan
@ 2008-11-12 1:24 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2008-11-12 1:24 UTC (permalink / raw)
To: adobriyan; +Cc: netdev
From: Alexey Dobriyan <adobriyan@gmail.com>
Date: Tue, 11 Nov 2008 15:07:40 +0300
> ->pde isn't actually needed, since name is stashed in ->id.
>
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-11-12 1:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-11 12:07 [PATCH] net: remove struct neigh_table::pde Alexey Dobriyan
2008-11-12 1:24 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox