* [PATCH] ixgbe: fix compilation with gcc-3.4
@ 2008-11-17 10:01 Alexey Dobriyan
2008-11-17 19:26 ` Waskiewicz Jr, Peter P
0 siblings, 1 reply; 3+ messages in thread
From: Alexey Dobriyan @ 2008-11-17 10:01 UTC (permalink / raw)
To: davem; +Cc: netdev
CC [M] drivers/net/ixgbe/ixgbe_main.o
drivers/net/ixgbe/ixgbe_main.c: In function `ixgbe_intr':
drivers/net/ixgbe/ixgbe_main.c:1290: sorry, unimplemented: inlining failed in call to 'ixgbe_irq_enable': function body not available
drivers/net/ixgbe/ixgbe_main.c:1312: sorry, unimplemented: called from here
make[4]: *** [drivers/net/ixgbe/ixgbe_main.o] Error 1
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---
drivers/net/ixgbe/ixgbe_main.c | 58 +++++++++++++++++++----------------------
1 file changed, 28 insertions(+), 30 deletions(-)
--- a/drivers/net/ixgbe/ixgbe_main.c
+++ b/drivers/net/ixgbe/ixgbe_main.c
@@ -1287,7 +1287,34 @@ static void ixgbe_set_itr(struct ixgbe_adapter *adapter)
return;
}
-static inline void ixgbe_irq_enable(struct ixgbe_adapter *adapter);
+/**
+ * ixgbe_irq_disable - Mask off interrupt generation on the NIC
+ * @adapter: board private structure
+ **/
+static inline void ixgbe_irq_disable(struct ixgbe_adapter *adapter)
+{
+ IXGBE_WRITE_REG(&adapter->hw, IXGBE_EIMC, ~0);
+ IXGBE_WRITE_FLUSH(&adapter->hw);
+ if (adapter->flags & IXGBE_FLAG_MSIX_ENABLED) {
+ int i;
+ for (i = 0; i < adapter->num_msix_vectors; i++)
+ synchronize_irq(adapter->msix_entries[i].vector);
+ } else {
+ synchronize_irq(adapter->pdev->irq);
+ }
+}
+
+/**
+ * ixgbe_irq_enable - Enable default interrupt generation settings
+ * @adapter: board private structure
+ **/
+static inline void ixgbe_irq_enable(struct ixgbe_adapter *adapter)
+{
+ u32 mask;
+ mask = IXGBE_EIMS_ENABLE_MASK;
+ IXGBE_WRITE_REG(&adapter->hw, IXGBE_EIMS, mask);
+ IXGBE_WRITE_FLUSH(&adapter->hw);
+}
/**
* ixgbe_intr - legacy mode Interrupt Handler
@@ -1394,35 +1421,6 @@ static void ixgbe_free_irq(struct ixgbe_adapter *adapter)
}
/**
- * ixgbe_irq_disable - Mask off interrupt generation on the NIC
- * @adapter: board private structure
- **/
-static inline void ixgbe_irq_disable(struct ixgbe_adapter *adapter)
-{
- IXGBE_WRITE_REG(&adapter->hw, IXGBE_EIMC, ~0);
- IXGBE_WRITE_FLUSH(&adapter->hw);
- if (adapter->flags & IXGBE_FLAG_MSIX_ENABLED) {
- int i;
- for (i = 0; i < adapter->num_msix_vectors; i++)
- synchronize_irq(adapter->msix_entries[i].vector);
- } else {
- synchronize_irq(adapter->pdev->irq);
- }
-}
-
-/**
- * ixgbe_irq_enable - Enable default interrupt generation settings
- * @adapter: board private structure
- **/
-static inline void ixgbe_irq_enable(struct ixgbe_adapter *adapter)
-{
- u32 mask;
- mask = IXGBE_EIMS_ENABLE_MASK;
- IXGBE_WRITE_REG(&adapter->hw, IXGBE_EIMS, mask);
- IXGBE_WRITE_FLUSH(&adapter->hw);
-}
-
-/**
* ixgbe_configure_msi_and_legacy - Initialize PIN (INTA...) and MSI interrupts
*
**/
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ixgbe: fix compilation with gcc-3.4
2008-11-17 10:01 [PATCH] ixgbe: fix compilation with gcc-3.4 Alexey Dobriyan
@ 2008-11-17 19:26 ` Waskiewicz Jr, Peter P
2008-11-19 22:17 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Waskiewicz Jr, Peter P @ 2008-11-17 19:26 UTC (permalink / raw)
To: Alexey Dobriyan; +Cc: davem@davemloft.net, netdev@vger.kernel.org
On Mon, 17 Nov 2008, Alexey Dobriyan wrote:
> CC [M] drivers/net/ixgbe/ixgbe_main.o
> drivers/net/ixgbe/ixgbe_main.c: In function `ixgbe_intr':
> drivers/net/ixgbe/ixgbe_main.c:1290: sorry, unimplemented: inlining failed in call to 'ixgbe_irq_enable': function body not available
> drivers/net/ixgbe/ixgbe_main.c:1312: sorry, unimplemented: called from here
> make[4]: *** [drivers/net/ixgbe/ixgbe_main.o] Error 1
>
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> ---
>
> drivers/net/ixgbe/ixgbe_main.c | 58 +++++++++++++++++++----------------------
> 1 file changed, 28 insertions(+), 30 deletions(-)
>
> --- a/drivers/net/ixgbe/ixgbe_main.c
> +++ b/drivers/net/ixgbe/ixgbe_main.c
> @@ -1287,7 +1287,34 @@ static void ixgbe_set_itr(struct ixgbe_adapter *adapter)
> return;
> }
>
> -static inline void ixgbe_irq_enable(struct ixgbe_adapter *adapter);
> +/**
> + * ixgbe_irq_disable - Mask off interrupt generation on the NIC
> + * @adapter: board private structure
> + **/
> +static inline void ixgbe_irq_disable(struct ixgbe_adapter *adapter)
> +{
> + IXGBE_WRITE_REG(&adapter->hw, IXGBE_EIMC, ~0);
> + IXGBE_WRITE_FLUSH(&adapter->hw);
> + if (adapter->flags & IXGBE_FLAG_MSIX_ENABLED) {
> + int i;
> + for (i = 0; i < adapter->num_msix_vectors; i++)
> + synchronize_irq(adapter->msix_entries[i].vector);
> + } else {
> + synchronize_irq(adapter->pdev->irq);
> + }
> +}
> +
> +/**
> + * ixgbe_irq_enable - Enable default interrupt generation settings
> + * @adapter: board private structure
> + **/
> +static inline void ixgbe_irq_enable(struct ixgbe_adapter *adapter)
> +{
> + u32 mask;
> + mask = IXGBE_EIMS_ENABLE_MASK;
> + IXGBE_WRITE_REG(&adapter->hw, IXGBE_EIMS, mask);
> + IXGBE_WRITE_FLUSH(&adapter->hw);
> +}
>
> /**
> * ixgbe_intr - legacy mode Interrupt Handler
> @@ -1394,35 +1421,6 @@ static void ixgbe_free_irq(struct ixgbe_adapter *adapter)
> }
>
> /**
> - * ixgbe_irq_disable - Mask off interrupt generation on the NIC
> - * @adapter: board private structure
> - **/
> -static inline void ixgbe_irq_disable(struct ixgbe_adapter *adapter)
> -{
> - IXGBE_WRITE_REG(&adapter->hw, IXGBE_EIMC, ~0);
> - IXGBE_WRITE_FLUSH(&adapter->hw);
> - if (adapter->flags & IXGBE_FLAG_MSIX_ENABLED) {
> - int i;
> - for (i = 0; i < adapter->num_msix_vectors; i++)
> - synchronize_irq(adapter->msix_entries[i].vector);
> - } else {
> - synchronize_irq(adapter->pdev->irq);
> - }
> -}
> -
> -/**
> - * ixgbe_irq_enable - Enable default interrupt generation settings
> - * @adapter: board private structure
> - **/
> -static inline void ixgbe_irq_enable(struct ixgbe_adapter *adapter)
> -{
> - u32 mask;
> - mask = IXGBE_EIMS_ENABLE_MASK;
> - IXGBE_WRITE_REG(&adapter->hw, IXGBE_EIMS, mask);
> - IXGBE_WRITE_FLUSH(&adapter->hw);
> -}
> -
> -/**
> * ixgbe_configure_msi_and_legacy - Initialize PIN (INTA...) and MSI interrupts
> *
> **/
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
Acked-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
-PJ Waskiewicz
<peter.p.waskiewicz.jr@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ixgbe: fix compilation with gcc-3.4
2008-11-17 19:26 ` Waskiewicz Jr, Peter P
@ 2008-11-19 22:17 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2008-11-19 22:17 UTC (permalink / raw)
To: peter.p.waskiewicz.jr; +Cc: adobriyan, netdev
From: "Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@intel.com>
Date: Mon, 17 Nov 2008 11:26:46 -0800 (Pacific Standard Time)
>
> On Mon, 17 Nov 2008, Alexey Dobriyan wrote:
>
> > CC [M] drivers/net/ixgbe/ixgbe_main.o
> > drivers/net/ixgbe/ixgbe_main.c: In function `ixgbe_intr':
> > drivers/net/ixgbe/ixgbe_main.c:1290: sorry, unimplemented: inlining failed in call to 'ixgbe_irq_enable': function body not available
> > drivers/net/ixgbe/ixgbe_main.c:1312: sorry, unimplemented: called from here
> > make[4]: *** [drivers/net/ixgbe/ixgbe_main.o] Error 1
> >
> > Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
...
> Acked-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-11-19 22:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-17 10:01 [PATCH] ixgbe: fix compilation with gcc-3.4 Alexey Dobriyan
2008-11-17 19:26 ` Waskiewicz Jr, Peter P
2008-11-19 22:17 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox