From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: "Jeff Kirsher" <jeffrey.t.kirsher@intel.com>
Cc: "Qinghuang Feng" <qhfeng.kernel@gmail.com>,
"David Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] driver/net/*: remove redundant argument comments
Date: Sat, 22 Nov 2008 11:40:14 +0000 [thread overview]
Message-ID: <20081122114014.379f2762@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <9929d2390811212355j635e0e8iee0e53678efc5f09@mail.gmail.com>
> > - * @rx_ring: pointer to receive ring structure
> > * @cleaned_count: number of buffers to allocate this pass
> > **/
> >
>
> NAK - rather than removing documentation, I would suggest improving
> the documentation.
I would suggest reading the patch more carefully - there is no rx_ring
argument. The documentation in the header is stale.
next prev parent reply other threads:[~2008-11-22 11:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-22 7:40 [PATCH 1/3] driver/net/*: remove redundant argument comments Qinghuang Feng
2008-11-22 7:55 ` Jeff Kirsher
2008-11-22 7:56 ` David Miller
2008-11-22 8:10 ` Jeff Kirsher
2008-11-22 11:40 ` Alan Cox [this message]
2008-11-23 23:47 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081122114014.379f2762@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=davem@davemloft.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=qhfeng.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox