From: "Jeff Kirsher" <jeffrey.t.kirsher@intel.com>
To: "David Miller" <davem@davemloft.net>
Cc: qhfeng.kernel@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] driver/net/*: remove redundant argument comments
Date: Sat, 22 Nov 2008 00:10:03 -0800 [thread overview]
Message-ID: <9929d2390811220010q5a064ccblc182ce0128250da6@mail.gmail.com> (raw)
In-Reply-To: <20081121.235656.193713995.davem@davemloft.net>
On Fri, Nov 21, 2008 at 11:56 PM, David Miller <davem@davemloft.net> wrote:
> From: "Jeff Kirsher" <jeffrey.t.kirsher@intel.com>
> Date: Fri, 21 Nov 2008 23:55:27 -0800
>
>> I would agree that "@rx_ring: pointer to receive ring structure" is
>> probably not the best documentation, but rather than removing it, I
>> would suggest improving it.
>
> Jeff, he's removing it because the function no longer takes
> that argument any more.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
I apologize, based on the patch comment of "remove redundant argument
comments" I took that he was removing comments that were "unnecessary
and repetitive" and not referring to "non-existent arguments".
I rescind my Nak.
--
Cheers,
Jeff
next prev parent reply other threads:[~2008-11-22 8:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-22 7:40 [PATCH 1/3] driver/net/*: remove redundant argument comments Qinghuang Feng
2008-11-22 7:55 ` Jeff Kirsher
2008-11-22 7:56 ` David Miller
2008-11-22 8:10 ` Jeff Kirsher [this message]
2008-11-22 11:40 ` Alan Cox
2008-11-23 23:47 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9929d2390811220010q5a064ccblc182ce0128250da6@mail.gmail.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=qhfeng.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox