From: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
To: David Miller <davem@davemloft.net>
Cc: thomas.petazzoni@free-electrons.com, netdev@vger.kernel.org,
michael@free-electrons.com
Subject: Re: [PATCH] macb: Add support of the netpoll API
Date: Fri, 17 Apr 2009 13:41:37 +0200 [thread overview]
Message-ID: <20090417134137.77b5dbd7@hskinnemoen-d830> (raw)
In-Reply-To: <20090417.034416.110856368.davem@davemloft.net>
David Miller wrote:
> From: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
> Date: Fri, 17 Apr 2009 11:50:11 +0200
>
> > No, therefore, I'd prefer local_irq_save() :-)
>
> I'm pretty sure there is a specific reason driver's use
> disable_irq() rather than disabling local cpu IRQs.
Looks like most if not all of the ARM drivers use local_irq_save()...I
couldn't figure out what etherh does from a quick scan.
> I just can't remember it at the moment.
>
> And there absolutely must be a reason, because disable_irq()
> is a lot more expensive.
Sounds like another reason _not_ to use it ;-)
Well, if you're really sure about this, I guess you might as well go
ahead and apply it. But it feels wrong to Ack the patch when I don't
know the reason for using disable_irq() and can think of several
reasons _not_ to use it...
Haavard
prev parent reply other threads:[~2009-04-17 11:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-15 13:46 [PATCH] macb: Add support of the netpoll API Thomas Petazzoni
2009-04-16 9:07 ` Haavard Skinnemoen
2009-04-16 9:24 ` Thomas Petazzoni
2009-04-16 10:31 ` Haavard Skinnemoen
2009-04-17 8:34 ` David Miller
2009-04-17 9:07 ` Haavard Skinnemoen
2009-04-17 9:08 ` David Miller
2009-04-17 9:25 ` Haavard Skinnemoen
2009-04-17 9:33 ` David Miller
2009-04-17 9:50 ` Haavard Skinnemoen
2009-04-17 10:44 ` David Miller
2009-04-17 11:39 ` David Miller
2009-04-20 10:57 ` Haavard Skinnemoen
2009-04-21 8:54 ` David Miller
2009-05-04 11:54 ` [PATCH v3] " Haavard Skinnemoen
2009-05-04 18:08 ` David Miller
2009-04-17 11:41 ` Haavard Skinnemoen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090417134137.77b5dbd7@hskinnemoen-d830 \
--to=haavard.skinnemoen@atmel.com \
--cc=davem@davemloft.net \
--cc=michael@free-electrons.com \
--cc=netdev@vger.kernel.org \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox