Re: [PATCH] macb: Add support of the netpoll API

[Haavard Skinnemoen <haavard.skinnemoen@atmel.com>]

Thomas Petazzoni wrote:
> macb: Add support of the netpoll API
> 
> With this patch in place, I'm successfully able to use the netconsole
> mechanism with the Calao USB-A9263 board, which uses the AT91SAM9263
> CPU, which in terms of Ethernet controller is supported by the macb
> driver.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
>  drivers/net/macb.c |   16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> Index: linux/drivers/net/macb.c
> ===================================================================
> --- linux.orig/drivers/net/macb.c
> +++ linux/drivers/net/macb.c
> @@ -616,6 +616,19 @@
>  	return IRQ_HANDLED;
>  }
>  
> +#ifdef CONFIG_NET_POLL_CONTROLLER
> +/*
> + * Polling receive - used by netconsole and other diagnostic tools
> + * to allow network i/o with interrupts disabled.
> + */
> +static void macb_poll_controller(struct net_device *dev)
> +{
> +	disable_irq(dev->irq);

Hmm...is this safe? What if printk() is called from the macb interrupt
handler?

Haavard