* [PATCH 1/2] netns 1/2: don't get/put old netns on CLONE_NEWNET
@ 2009-05-03 23:28 Alexey Dobriyan
2009-05-04 18:11 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Alexey Dobriyan @ 2009-05-03 23:28 UTC (permalink / raw)
To: davem; +Cc: linux-kernel, containers, netdev
copy_net_ns() doesn't copy anything, it creates fresh netns, so get/put of old
netns isn't needed.
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Acked-by: Serge Hallyn <serue@us.ibm.com>
---
net/core/net_namespace.c | 5 +----
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/net/core/net_namespace.c b/net/core/net_namespace.c
index e3bebd3..4488010 100644
--- a/net/core/net_namespace.c
+++ b/net/core/net_namespace.c
@@ -120,10 +120,8 @@ struct net *copy_net_ns(unsigned long flags, struct net *old_net)
struct net *new_net = NULL;
int err;
- get_net(old_net);
-
if (!(flags & CLONE_NEWNET))
- return old_net;
+ return get_net(old_net);
err = -ENOMEM;
new_net = net_alloc();
@@ -142,7 +140,6 @@ struct net *copy_net_ns(unsigned long flags, struct net *old_net)
if (err)
goto out_free;
out:
- put_net(old_net);
return new_net;
out_free:
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/2] netns 1/2: don't get/put old netns on CLONE_NEWNET
2009-05-03 23:28 [PATCH 1/2] netns 1/2: don't get/put old netns on CLONE_NEWNET Alexey Dobriyan
@ 2009-05-04 18:11 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-05-04 18:11 UTC (permalink / raw)
To: adobriyan; +Cc: linux-kernel, containers, netdev
From: Alexey Dobriyan <adobriyan@gmail.com>
Date: Mon, 4 May 2009 03:28:25 +0400
> copy_net_ns() doesn't copy anything, it creates fresh netns, so get/put of old
> netns isn't needed.
>
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> Acked-by: Serge Hallyn <serue@us.ibm.com>
Applied to net-next-2.6
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-05-04 18:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-05-03 23:28 [PATCH 1/2] netns 1/2: don't get/put old netns on CLONE_NEWNET Alexey Dobriyan
2009-05-04 18:11 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox