[PATCH 1/2] netdev: smsc911x: allow building on Blackfin systems

[PATCH 1/2] netdev: smsc911x: allow building on Blackfin systems

[Mike Frysinger]

The smsc911x driver works fine on Blackfin systems, so add it to the arch
list in the Kconfig.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
side note ... does it even make sense to have this arch list in the first
place ?  the driver works with any platform who declares proper platform
resources ...

 drivers/net/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index 214a92d..962b261 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -1000,7 +1000,7 @@ config SMC911X
 
 config SMSC911X
 	tristate "SMSC LAN911x/LAN921x families embedded ethernet support"
-	depends on ARM || SUPERH
+	depends on ARM || SUPERH || BLACKFIN
 	select CRC32
 	select MII
 	select PHYLIB
-- 
1.6.3.1

[PATCH 2/2] netdev: smsc911x: add missing __devexit_p() usage

[Mike Frysinger]

The smsc911x_drv_remove() function is declared with __devexit, so the
assignment to the driver structure needs __devexit_p() wrappings to prevent
build failure when hotplug is disabled.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
 drivers/net/smsc911x.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/smsc911x.c b/drivers/net/smsc911x.c
index eb7db03..d3bf943 100644
--- a/drivers/net/smsc911x.c
+++ b/drivers/net/smsc911x.c
@@ -2098,7 +2098,7 @@ out_0:
 
 static struct platform_driver smsc911x_driver = {
 	.probe = smsc911x_drv_probe,
-	.remove = smsc911x_drv_remove,
+	.remove = __devexit_p(smsc911x_drv_remove),
 	.driver = {
 		.name = SMSC_CHIPNAME,
 	},
-- 
1.6.3.1

Re: [PATCH 2/2] netdev: smsc911x: add missing __devexit_p() usage

[David Miller]

From: Mike Frysinger <vapier@gentoo.org>
Date: Fri,  5 Jun 2009 20:37:20 -0400

> The smsc911x_drv_remove() function is declared with __devexit, so the
> assignment to the driver structure needs __devexit_p() wrappings to prevent
> build failure when hotplug is disabled.
> 
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>

Applied.

Re: [PATCH 2/2] netdev: smsc911x: add missing __devexit_p() usage

[Steve.Glendinning-sdUf+H5yV5I]

> The smsc911x_drv_remove() function is declared with __devexit, so the
> assignment to the driver structure needs __devexit_p() wrappings to 
prevent
> build failure when hotplug is disabled.
> 
> Signed-off-by: Mike Frysinger <vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>

Acked-by: Steve Glendinning <steve.glendinning-sdUf+H5yV5I@public.gmane.org>

Re: [PATCH 1/2] netdev: smsc911x: allow building on Blackfin systems

[David Miller]

From: Mike Frysinger <vapier@gentoo.org>
Date: Fri,  5 Jun 2009 20:37:19 -0400

> The smsc911x driver works fine on Blackfin systems, so add it to the arch
> list in the Kconfig.
> 
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>

Applied.

> side note ... does it even make sense to have this arch list in the first
> place ?  the driver works with any platform who declares proper platform
> resources ...

I agree, we should probably get rid of the conditional arch list.

Re: [PATCH 1/2] netdev: smsc911x: allow building on Blackfin systems

[Steve.Glendinning]

> The smsc911x driver works fine on Blackfin systems, so add it to the 
arch
> list in the Kconfig.
> 
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>

Acked-by: Steve Glendinning <steve.glendinning@smsc.com>

> side note ... does it even make sense to have this arch list in the 
first
> place ?  the driver works with any platform who declares proper platform
> resources ...

You're right, there's nothing "special" about ARM | SUPERH other than they 
cover all the in-tree platforms using smsc911x.  The aim was to hide this 
option from menuconfig on x86 etc, where this device is extremely unlikely 
to be found.  Maybe there's a better way of doing this?

Steve

RE: [Uclinux-dist-devel] [PATCH 1/2] netdev: smsc911x: allowbuilding on Blackfin systems

[Hennerich, Michael]

if EMBEDDED ?



>From: uclinux-dist-devel-bounces@blackfin.uclinux.org
[mailto:uclinux-dist-devel-
>bounces@blackfin.uclinux.org] On Behalf Of Steve.Glendinning@smsc.com
>> The smsc911x driver works fine on Blackfin systems, so add it to the
>arch
>> list in the Kconfig.
>>
>> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
>
>Acked-by: Steve Glendinning <steve.glendinning@smsc.com>
>
>> side note ... does it even make sense to have this arch list in the
>first
>> place ?  the driver works with any platform who declares proper
platform
>> resources ...
>
>You're right, there's nothing "special" about ARM | SUPERH other than
they
>cover all the in-tree platforms using smsc911x.  The aim was to hide
this
>option from menuconfig on x86 etc, where this device is extremely
unlikely
>to be found.  Maybe there's a better way of doing this?
>
>Steve

if EMBEDDED ?

-Michael

Re: [PATCH 1/2] netdev: smsc911x: allow building on Blackfin systems

[David Miller]

From: Steve.Glendinning@smsc.com
Date: Mon, 8 Jun 2009 20:36:24 +0100

> You're right, there's nothing "special" about ARM | SUPERH other than they 
> cover all the in-tree platforms using smsc911x.  The aim was to hide this 
> option from menuconfig on x86 etc, where this device is extremely unlikely 
> to be found.  Maybe there's a better way of doing this?

I sincerely doubt keeping this out of x86's menuconfig so important,
really.

So many devices are available for powerpc and sparc64 that will never
appear there, however those drivers now get build validated on those
platforms and it's therefore a net-win.

Re: [Uclinux-dist-devel] [PATCH 1/2] netdev: smsc911x: allow building on Blackfin systems

[Mike Frysinger]

On Mon, Jun 8, 2009 at 17:37, David Miller wrote:
> From: Steve.Glendinning@smsc.com
>> You're right, there's nothing "special" about ARM | SUPERH other than they
>> cover all the in-tree platforms using smsc911x.  The aim was to hide this
>> option from menuconfig on x86 etc, where this device is extremely unlikely
>> to be found.  Maybe there's a better way of doing this?
>
> I sincerely doubt keeping this out of x86's menuconfig so important,
> really.

and desktop systems' menuconfig is so big that i dont think one more
driver will make a difference

> So many devices are available for powerpc and sparc64 that will never
> appear there, however those drivers now get build validated on those
> platforms and it's therefore a net-win.

i run randconfigs nightly ... it's neat the kind of unlikely build bugs you find
-mike

Re: [PATCH 1/2] netdev: smsc911x: allow building on Blackfin systems

[Steve.Glendinning-sdUf+H5yV5I]

Mike Frysinger <vapier.adi-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote on 08/06/2009 22:50:32:
> On Mon, Jun 8, 2009 at 17:37, David Miller wrote:
> > So many devices are available for powerpc and sparc64 that will never
> > appear there, however those drivers now get build validated on those
> > platforms and it's therefore a net-win.
> 
> i run randconfigs nightly ... it's neat the kind of unlikely build bugs 
you find
> -mike

Sounds great, do you want to modify your patch to remove the line 
altogether?

Thanks,
Steve

[PATCH 1/2 v2] netdev: smsc911x: allow building on any system

[Mike Frysinger]

The smsc911x driver should build fine on any system as it contains no arch
specific code (all platform resources), and any platform that has
appropriate resources should run fine (as it does on Blackfin systems).

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
v2
	- drop the depends line completely

 drivers/net/Kconfig |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index 214a92d..8c92abd 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -1000,7 +1000,6 @@ config SMC911X
 
 config SMSC911X
 	tristate "SMSC LAN911x/LAN921x families embedded ethernet support"
-	depends on ARM || SUPERH
 	select CRC32
 	select MII
 	select PHYLIB
-- 
1.6.3.1

Re: [PATCH 1/2 v2] netdev: smsc911x: allow building on any system

[David Miller]

From: Mike Frysinger <vapier@gentoo.org>
Date: Tue,  9 Jun 2009 04:22:22 -0400

> The smsc911x driver should build fine on any system as it contains no arch
> specific code (all platform resources), and any platform that has
> appropriate resources should run fine (as it does on Blackfin systems).
> 
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>

Mike I already applied your previous patch.

You'll need to send me a patch relative to that.

[PATCH 1/2 v3] netdev: smsc911x: allow building on any system

[Mike Frysinger]

The smsc911x driver should build fine on any system as it contains no arch
specific code (all platform resources), and any platform that has
appropriate resources should run fine.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
v3
	- based on net-next

 drivers/net/Kconfig |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index 962b261..8c92abd 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -1000,7 +1000,6 @@ config SMC911X
 
 config SMSC911X
 	tristate "SMSC LAN911x/LAN921x families embedded ethernet support"
-	depends on ARM || SUPERH || BLACKFIN
 	select CRC32
 	select MII
 	select PHYLIB
-- 
1.6.3.1

Re: [PATCH 1/2 v3] netdev: smsc911x: allow building on any system

[David Miller]

From: Mike Frysinger <vapier@gentoo.org>
Date: Tue,  9 Jun 2009 05:13:39 -0400

> The smsc911x driver should build fine on any system as it contains no arch
> specific code (all platform resources), and any platform that has
> appropriate resources should run fine.
> 
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>

Where is patch 2/2 :-)

Re: [Uclinux-dist-devel] [PATCH 1/2 v3] netdev: smsc911x: allow building on any system

[Mike Frysinger]

On Tue, Jun 9, 2009 at 06:59, David Miller wrote:
> From: Mike Frysinger <vapier@gentoo.org>
>> The smsc911x driver should build fine on any system as it contains no arch
>> specific code (all platform resources), and any platform that has
>> appropriate resources should run fine.
>>
>> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
>
> Where is patch 2/2 :-)

meh, call this patch 1.5 since it doesnt replace the previous 1/2 like
v2 did.  there is no 2/2.
-mike

Re: [PATCH 1/2 v3] netdev: smsc911x: allow building on any system

[David Miller]

From: Mike Frysinger <vapier@gentoo.org>
Date: Tue,  9 Jun 2009 05:13:39 -0400

> The smsc911x driver should build fine on any system as it contains no arch
> specific code (all platform resources), and any platform that has
> appropriate resources should run fine.
> 
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>

Applied.

Re: [PATCH 1/2 v3] netdev: smsc911x: allow building on any system

[David Miller]

From: David Miller <davem@davemloft.net>
Date: Tue, 09 Jun 2009 05:21:36 -0700 (PDT)

> From: Mike Frysinger <vapier@gentoo.org>
> Date: Tue,  9 Jun 2009 05:13:39 -0400
> 
>> The smsc911x driver should build fine on any system as it contains no arch
>> specific code (all platform resources), and any platform that has
>> appropriate resources should run fine.
>> 
>> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> 
> Applied.

Actually, I have to revert.

Not all platforms implement writesl(), readsl(), etc.
The build failed on sparc64, for example.