From: David Miller <davem@davemloft.net>
To: greearb@candelatech.com
Cc: netdev@vger.kernel.org
Subject: Re: PATCH: veth: Zero timestamp in xmit path.
Date: Tue, 21 Jul 2009 12:51:55 -0700 (PDT) [thread overview]
Message-ID: <20090721.125155.168882282.davem@davemloft.net> (raw)
In-Reply-To: <4A661B2F.7000608@candelatech.com>
From: Ben Greear <greearb@candelatech.com>
Date: Tue, 21 Jul 2009 12:46:55 -0700
> This patch zero's the timestamp before handing the packet to
> the peer interface. This lets the peer recalculate the rx timestamp
> if it cares about timestamps.
>
> The patch is against net-next, compile tested there. Similar patch
> was
> functionally tested against 2.6.31-rc3.
>
>
> Signed-Off-By: Ben Greear<greearb@candelatech.com>
Oh, where to begin... sigh...
The "off" and "by" in "Signed-off-by" is not capitalized.
There should not be two spaces after the Signed-off-by colon, there
should be only one.
There should be a space between your name and your <> enclosed email
address.
> @@ -171,6 +171,7 @@ static int veth_xmit(struct sk_buff *skb, struct
> net_device *dev)
Your email client corrupted the patch by splitting up this line.
This is all just being sloppy, and it shows a lack of care put
into your submission.
Nevertheless I'm a sucker and I fixed this all up and applied your
patch.
next prev parent reply other threads:[~2009-07-21 19:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-21 19:46 PATCH: veth: Zero timestamp in xmit path Ben Greear
2009-07-21 19:51 ` David Miller [this message]
2009-07-21 20:02 ` Ben Greear
2009-07-21 20:05 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090721.125155.168882282.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=greearb@candelatech.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox