From: David Miller <davem@davemloft.net>
To: greearb@candelatech.com
Cc: netdev@vger.kernel.org
Subject: Re: PATCH: veth: Zero timestamp in xmit path.
Date: Tue, 21 Jul 2009 13:05:42 -0700 (PDT) [thread overview]
Message-ID: <20090721.130542.158855009.davem@davemloft.net> (raw)
In-Reply-To: <4A661EBA.7040206@candelatech.com>
From: Ben Greear <greearb@candelatech.com>
Date: Tue, 21 Jul 2009 13:02:02 -0700
> On 07/21/2009 12:51 PM, David Miller wrote:
>> From: Ben Greear<greearb@candelatech.com>
>> Date: Tue, 21 Jul 2009 12:46:55 -0700
>>
>>> Signed-Off-By: Ben Greear<greearb@candelatech.com>
>>
>> Oh, where to begin... sigh...
>>
>> The "off" and "by" in "Signed-off-by" is not capitalized.
>>
>> There should not be two spaces after the Signed-off-by colon, there
>> should be only one.
>>
>> There should be a space between your name and your<> enclosed email
>> address.
>
> I had no idea that was so important.
If you aren't even going to check over such easy and trivial visual
matters such as this, one can only imagine how much care has been put
into the change itself.
It shows how much you care about how your work and submissions look to
other people.
It's as much an issue of what it shows about the submitter's overall
mentality as it is an issue of "does it matter" or how important it is
to get the signoff syntax correct.
prev parent reply other threads:[~2009-07-21 20:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-21 19:46 PATCH: veth: Zero timestamp in xmit path Ben Greear
2009-07-21 19:51 ` David Miller
2009-07-21 20:02 ` Ben Greear
2009-07-21 20:05 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090721.130542.158855009.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=greearb@candelatech.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox