* [PATCH -next] netxen: fix build when CONFIG_INET=n [not found] <20090728174224.647cc3ba.sfr@canb.auug.org.au> @ 2009-07-28 18:21 ` Randy Dunlap 2009-07-28 18:25 ` Dhananjay Phadke 0 siblings, 1 reply; 3+ messages in thread From: Randy Dunlap @ 2009-07-28 18:21 UTC (permalink / raw) To: Stephen Rothwell, davem; +Cc: linux-next, LKML, netdev, Dhananjay Phadke From: Randy Dunlap <randy.dunlap@oracle.com> Fix netxen build errors when CONFIG_INET=n: netxen_nic_main.c:(.text+0x1abb8a): undefined reference to `in_dev_finish_destroy' netxen_nic_main.c:(.init.text+0xd86e): undefined reference to `register_inetaddr_notifier' netxen_nic_main.c:(.exit.text+0x1b70): undefined reference to `unregister_inetaddr_notifier' Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> Cc: Dhananjay Phadke <dhananjay@netxen.com> --- drivers/net/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20090728.orig/drivers/net/Kconfig +++ linux-next-20090728/drivers/net/Kconfig @@ -2666,7 +2666,7 @@ config MYRI10GE_DCA config NETXEN_NIC tristate "NetXen Multi port (1/10) Gigabit Ethernet NIC" - depends on PCI + depends on PCI && INET help This enables the support for NetXen's Gigabit Ethernet card. --- ~Randy LPC 2009, Sept. 23-25, Portland, Oregon http://linuxplumbersconf.org/2009/ ^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH -next] netxen: fix build when CONFIG_INET=n 2009-07-28 18:21 ` [PATCH -next] netxen: fix build when CONFIG_INET=n Randy Dunlap @ 2009-07-28 18:25 ` Dhananjay Phadke 2009-07-28 18:32 ` Randy Dunlap 0 siblings, 1 reply; 3+ messages in thread From: Dhananjay Phadke @ 2009-07-28 18:25 UTC (permalink / raw) To: Randy Dunlap, Stephen Rothwell, davem@davemloft.net Cc: linux-next@vger.kernel.org, LKML, netdev Thanks Randy for catching, I didn't run CONFIG_INET=n build. I think, better option is to wrap code in netxen_nic_main.c with CONFIG_INET check, since it's not a mandatory feature. -Dhananjay ________________________________________ From: Randy Dunlap [randy.dunlap@oracle.com] Sent: Tuesday, July 28, 2009 11:21 AM To: Stephen Rothwell; davem@davemloft.net Cc: linux-next@vger.kernel.org; LKML; netdev; Dhananjay Phadke Subject: [PATCH -next] netxen: fix build when CONFIG_INET=n From: Randy Dunlap <randy.dunlap@oracle.com> Fix netxen build errors when CONFIG_INET=n: netxen_nic_main.c:(.text+0x1abb8a): undefined reference to `in_dev_finish_destroy' netxen_nic_main.c:(.init.text+0xd86e): undefined reference to `register_inetaddr_notifier' netxen_nic_main.c:(.exit.text+0x1b70): undefined reference to `unregister_inetaddr_notifier' Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> Cc: Dhananjay Phadke <dhananjay@netxen.com> --- drivers/net/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20090728.orig/drivers/net/Kconfig +++ linux-next-20090728/drivers/net/Kconfig @@ -2666,7 +2666,7 @@ config MYRI10GE_DCA config NETXEN_NIC tristate "NetXen Multi port (1/10) Gigabit Ethernet NIC" - depends on PCI + depends on PCI && INET help This enables the support for NetXen's Gigabit Ethernet card. --- ~Randy LPC 2009, Sept. 23-25, Portland, Oregon http://linuxplumbersconf.org/2009/ ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] netxen: fix build when CONFIG_INET=n 2009-07-28 18:25 ` Dhananjay Phadke @ 2009-07-28 18:32 ` Randy Dunlap 0 siblings, 0 replies; 3+ messages in thread From: Randy Dunlap @ 2009-07-28 18:32 UTC (permalink / raw) To: Dhananjay Phadke Cc: Stephen Rothwell, davem@davemloft.net, linux-next@vger.kernel.org, LKML, netdev On Tue, 28 Jul 2009 11:25:19 -0700 Dhananjay Phadke wrote: > Thanks Randy for catching, I didn't run CONFIG_INET=n build. > > I think, better option is to wrap code in netxen_nic_main.c with CONFIG_INET check, > since it's not a mandatory feature. OK, I'll leave that to you then. > -Dhananjay > ________________________________________ > From: Randy Dunlap [randy.dunlap@oracle.com] > Sent: Tuesday, July 28, 2009 11:21 AM > To: Stephen Rothwell; davem@davemloft.net > Cc: linux-next@vger.kernel.org; LKML; netdev; Dhananjay Phadke > Subject: [PATCH -next] netxen: fix build when CONFIG_INET=n > > From: Randy Dunlap <randy.dunlap@oracle.com> > > Fix netxen build errors when CONFIG_INET=n: > > netxen_nic_main.c:(.text+0x1abb8a): undefined reference to `in_dev_finish_destroy' > netxen_nic_main.c:(.init.text+0xd86e): undefined reference to `register_inetaddr_notifier' > netxen_nic_main.c:(.exit.text+0x1b70): undefined reference to `unregister_inetaddr_notifier' > > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> > Cc: Dhananjay Phadke <dhananjay@netxen.com> > --- > drivers/net/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- linux-next-20090728.orig/drivers/net/Kconfig > +++ linux-next-20090728/drivers/net/Kconfig > @@ -2666,7 +2666,7 @@ config MYRI10GE_DCA > > config NETXEN_NIC > tristate "NetXen Multi port (1/10) Gigabit Ethernet NIC" > - depends on PCI > + depends on PCI && INET > help > This enables the support for NetXen's Gigabit Ethernet card. > > > > > --- > ~Randy > LPC 2009, Sept. 23-25, Portland, Oregon > http://linuxplumbersconf.org/2009/ --- ~Randy LPC 2009, Sept. 23-25, Portland, Oregon http://linuxplumbersconf.org/2009/ ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-07-28 18:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20090728174224.647cc3ba.sfr@canb.auug.org.au>
2009-07-28 18:21 ` [PATCH -next] netxen: fix build when CONFIG_INET=n Randy Dunlap
2009-07-28 18:25 ` Dhananjay Phadke
2009-07-28 18:32 ` Randy Dunlap
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox