* [PATCH] smsc95xx: remove EEPROM loaded check
@ 2009-07-28 12:37 Steve Glendinning
2009-08-02 19:56 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Steve Glendinning @ 2009-07-28 12:37 UTC (permalink / raw)
To: netdev; +Cc: Ian Saturley, David Miller, Steve Glendinning
The eeprom read & write commands currently check the E2P_CMD_LOADED_ bit is
set before allowing any operations. This prevents any reading or writing
unless a correctly programmed EEPROM is installed.
This patch removes the check, so it is possible to program blank EEPROMS
via ethtool.
Signed-off-by: Steve Glendinning <steve.glendinning@smsc.com>
---
drivers/net/usb/smsc95xx.c | 5 -----
1 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c
index fe04589..09bd635 100644
--- a/drivers/net/usb/smsc95xx.c
+++ b/drivers/net/usb/smsc95xx.c
@@ -220,11 +220,6 @@ static int smsc95xx_eeprom_confirm_not_busy(struct usbnet *dev)
do {
smsc95xx_read_reg(dev, E2P_CMD, &val);
- if (!(val & E2P_CMD_LOADED_)) {
- devwarn(dev, "No EEPROM present");
- return -EIO;
- }
-
if (!(val & E2P_CMD_BUSY_))
return 0;
--
1.6.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] smsc95xx: remove EEPROM loaded check
2009-07-28 12:37 [PATCH] smsc95xx: remove EEPROM loaded check Steve Glendinning
@ 2009-08-02 19:56 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-08-02 19:56 UTC (permalink / raw)
To: steve.glendinning; +Cc: netdev, ian.saturley
From: Steve Glendinning <steve.glendinning@smsc.com>
Date: Tue, 28 Jul 2009 13:37:58 +0100
> The eeprom read & write commands currently check the E2P_CMD_LOADED_ bit is
> set before allowing any operations. This prevents any reading or writing
> unless a correctly programmed EEPROM is installed.
>
> This patch removes the check, so it is possible to program blank EEPROMS
> via ethtool.
>
> Signed-off-by: Steve Glendinning <steve.glendinning@smsc.com>
Applied to net-next-2.6
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-08-02 19:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-28 12:37 [PATCH] smsc95xx: remove EEPROM loaded check Steve Glendinning
2009-08-02 19:56 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox