* [PATCH 1/5] tc35815: Disable StripCRC
@ 2009-08-06 14:41 Atsushi Nemoto
2009-08-06 20:16 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Atsushi Nemoto @ 2009-08-06 14:41 UTC (permalink / raw)
To: netdev; +Cc: David Miller, Ralf Roesch
It seems Rx_StripCRC cause trouble on recovering from the BLEx (Buffer
List Exhaust) or FDAEx (Free Descriptor Area Exhaust) condition.
Do not use it.
Also bump version number up.
Reported-by: Ralf Roesch <ralf.roesch@rw-gmbh.de>
Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
---
drivers/net/tc35815.c | 7 ++++---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/net/tc35815.c b/drivers/net/tc35815.c
index d737f6b..c903a68 100644
--- a/drivers/net/tc35815.c
+++ b/drivers/net/tc35815.c
@@ -23,9 +23,9 @@
*/
#ifdef TC35815_NAPI
-#define DRV_VERSION "1.37-NAPI"
+#define DRV_VERSION "1.38-NAPI"
#else
-#define DRV_VERSION "1.37"
+#define DRV_VERSION "1.38"
#endif
static const char *version = "tc35815.c:v" DRV_VERSION "\n";
#define MODNAME "tc35815"
@@ -341,8 +341,9 @@ struct BDesc {
Tx_EnExColl | Tx_EnLCarr | Tx_EnExDefer | Tx_EnUnder | \
Tx_En) /* maybe 0x7b01 */
#endif
+/* Do not use Rx_StripCRC -- it causes trouble on BLEx/FDAEx condition */
#define RX_CTL_CMD (Rx_EnGood | Rx_EnRxPar | Rx_EnLongErr | Rx_EnOver \
- | Rx_EnCRCErr | Rx_EnAlign | Rx_StripCRC | Rx_RxEn) /* maybe 0x6f11 */
+ | Rx_EnCRCErr | Rx_EnAlign | Rx_RxEn) /* maybe 0x6f01 */
#define INT_EN_CMD (Int_NRAbtEn | \
Int_DmParErrEn | Int_DParDEn | Int_DParErrEn | \
Int_SSysErrEn | Int_RMasAbtEn | Int_RTargAbtEn | \
--
1.5.6.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 1/5] tc35815: Disable StripCRC
2009-08-06 14:41 [PATCH 1/5] tc35815: Disable StripCRC Atsushi Nemoto
@ 2009-08-06 20:16 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-08-06 20:16 UTC (permalink / raw)
To: anemo; +Cc: netdev, ralf.roesch
From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Date: Thu, 6 Aug 2009 23:41:45 +0900
> It seems Rx_StripCRC cause trouble on recovering from the BLEx (Buffer
> List Exhaust) or FDAEx (Free Descriptor Area Exhaust) condition.
> Do not use it.
>
> Also bump version number up.
>
> Reported-by: Ralf Roesch <ralf.roesch@rw-gmbh.de>
> Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Applied to net-next-2.6
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-08-06 20:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-08-06 14:41 [PATCH 1/5] tc35815: Disable StripCRC Atsushi Nemoto
2009-08-06 20:16 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox