From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: joamaki@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH] Fix xfrm hash collisions by changing __xfrm4_daddr_saddr_hash to hash addresses with addition
Date: Wed, 12 Aug 2009 20:56:35 -0700 (PDT) [thread overview]
Message-ID: <20090812.205635.244644770.davem@davemloft.net> (raw)
In-Reply-To: <20090813035310.GA19182@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Thu, 13 Aug 2009 13:53:10 +1000
> Take corporate VPN servers for instance. Yes each client is
> trusted to the extent that it is being offered connectivity to
> the corporate network. However, it would not be ideal if one
> rogue client can take down the entire VPN server, especially
> in this case because repeatedly creating identical SAs can often
> occur purely by accident.
1) The client is on your private network, much more serious
mischief is possible.
2) Whoever creates such a hash collision explosion can be
precisely identified.
The ikev1 failure case is an interesting situation I hadn't
considered.
Maybe that can matter, but again the guilty party is easy to identify
and easy to block via whatever means appropriate.
next prev parent reply other threads:[~2009-08-13 3:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-05 7:41 [PATCH] xfrm: xfrm hash to use Jenkins' hash Jussi Mäki
2009-08-05 8:39 ` Jussi Maki
2009-08-05 19:08 ` David Miller
2009-08-06 6:32 ` Jussi Maki
2009-08-06 8:58 ` Jussi Maki
2009-08-06 17:40 ` David Miller
2009-08-07 7:38 ` [PATCH] Fix xfrm hash collisions by changing __xfrm4_daddr_saddr_hash to hash addresses with addition Jussi Maki
2009-08-10 4:52 ` David Miller
2009-08-13 2:06 ` Herbert Xu
2009-08-13 3:42 ` David Miller
2009-08-13 3:53 ` Herbert Xu
2009-08-13 3:56 ` David Miller [this message]
2009-08-13 4:11 ` Herbert Xu
2009-08-13 4:18 ` David Miller
2009-08-13 4:19 ` Herbert Xu
2009-08-06 17:40 ` [PATCH] xfrm: xfrm hash to use Jenkins' hash David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090812.205635.244644770.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=joamaki@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox