* [PATCH net-next-2.6] netlink: fix typo in initialization
@ 2009-10-08 7:23 Jiri Pirko
2009-10-08 7:57 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Jiri Pirko @ 2009-10-08 7:23 UTC (permalink / raw)
To: netdev; +Cc: davem, kaber
Commit 9ef1d4c7c7aca1cd436612b6ca785b726ffb8ed8 introduced a typo in
initialization. This patch fixes this.
Signed-off-by: Jiri Pirko <jpirko@redhat.com>
diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c
index 6a53694..7cf6c0f 100644
--- a/net/sched/cls_api.c
+++ b/net/sched/cls_api.c
@@ -350,7 +350,7 @@ static int tcf_fill_node(struct sk_buff *skb, struct tcf_proto *tp,
tcm = NLMSG_DATA(nlh);
tcm->tcm_family = AF_UNSPEC;
tcm->tcm__pad1 = 0;
- tcm->tcm__pad1 = 0;
+ tcm->tcm__pad2 = 0;
tcm->tcm_ifindex = qdisc_dev(tp->q)->ifindex;
tcm->tcm_parent = tp->classid;
tcm->tcm_info = TC_H_MAKE(tp->prio, tp->protocol);
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net-next-2.6] netlink: fix typo in initialization
2009-10-08 7:23 [PATCH net-next-2.6] netlink: fix typo in initialization Jiri Pirko
@ 2009-10-08 7:57 ` David Miller
2009-10-08 8:08 ` Jiri Pirko
0 siblings, 1 reply; 4+ messages in thread
From: David Miller @ 2009-10-08 7:57 UTC (permalink / raw)
To: jpirko; +Cc: netdev, kaber
From: Jiri Pirko <jpirko@redhat.com>
Date: Thu, 8 Oct 2009 09:23:23 +0200
> Commit 9ef1d4c7c7aca1cd436612b6ca785b726ffb8ed8 introduced a typo in
> initialization. This patch fixes this.
>
> Signed-off-by: Jiri Pirko <jpirko@redhat.com>
Doesn't this leak some uninitialized bytes to userspace?
Therefore, this fix probably belongs in net-2.6 and -stable instead
of net-next-2.6, right?
> diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c
> index 6a53694..7cf6c0f 100644
> --- a/net/sched/cls_api.c
> +++ b/net/sched/cls_api.c
> @@ -350,7 +350,7 @@ static int tcf_fill_node(struct sk_buff *skb, struct tcf_proto *tp,
> tcm = NLMSG_DATA(nlh);
> tcm->tcm_family = AF_UNSPEC;
> tcm->tcm__pad1 = 0;
> - tcm->tcm__pad1 = 0;
> + tcm->tcm__pad2 = 0;
> tcm->tcm_ifindex = qdisc_dev(tp->q)->ifindex;
> tcm->tcm_parent = tp->classid;
> tcm->tcm_info = TC_H_MAKE(tp->prio, tp->protocol);
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next-2.6] netlink: fix typo in initialization
2009-10-08 7:57 ` David Miller
@ 2009-10-08 8:08 ` Jiri Pirko
2009-10-08 8:20 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Jiri Pirko @ 2009-10-08 8:08 UTC (permalink / raw)
To: David Miller; +Cc: netdev, kaber
Thu, Oct 08, 2009 at 09:57:43AM CEST, davem@davemloft.net wrote:
>From: Jiri Pirko <jpirko@redhat.com>
>Date: Thu, 8 Oct 2009 09:23:23 +0200
>
>> Commit 9ef1d4c7c7aca1cd436612b6ca785b726ffb8ed8 introduced a typo in
>> initialization. This patch fixes this.
>>
>> Signed-off-by: Jiri Pirko <jpirko@redhat.com>
>
>Doesn't this leak some uninitialized bytes to userspace?
Yes it does.
>
>Therefore, this fix probably belongs in net-2.6 and -stable instead
>of net-next-2.6, right?
Okay. The patch is applicable on net-2.6 (I presume on -stable too). Feel free
to apply.
Thanks.
Jirka
>
>> diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c
>> index 6a53694..7cf6c0f 100644
>> --- a/net/sched/cls_api.c
>> +++ b/net/sched/cls_api.c
>> @@ -350,7 +350,7 @@ static int tcf_fill_node(struct sk_buff *skb, struct tcf_proto *tp,
>> tcm = NLMSG_DATA(nlh);
>> tcm->tcm_family = AF_UNSPEC;
>> tcm->tcm__pad1 = 0;
>> - tcm->tcm__pad1 = 0;
>> + tcm->tcm__pad2 = 0;
>> tcm->tcm_ifindex = qdisc_dev(tp->q)->ifindex;
>> tcm->tcm_parent = tp->classid;
>> tcm->tcm_info = TC_H_MAKE(tp->prio, tp->protocol);
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next-2.6] netlink: fix typo in initialization
2009-10-08 8:08 ` Jiri Pirko
@ 2009-10-08 8:20 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2009-10-08 8:20 UTC (permalink / raw)
To: jpirko; +Cc: netdev, kaber
From: Jiri Pirko <jpirko@redhat.com>
Date: Thu, 8 Oct 2009 10:08:59 +0200
> Thu, Oct 08, 2009 at 09:57:43AM CEST, davem@davemloft.net wrote:
>>From: Jiri Pirko <jpirko@redhat.com>
>>Date: Thu, 8 Oct 2009 09:23:23 +0200
>>
>>Therefore, this fix probably belongs in net-2.6 and -stable instead
>>of net-next-2.6, right?
>
> Okay. The patch is applicable on net-2.6 (I presume on -stable too). Feel free
> to apply.
Great, I'll take care of this, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-10-08 8:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-08 7:23 [PATCH net-next-2.6] netlink: fix typo in initialization Jiri Pirko
2009-10-08 7:57 ` David Miller
2009-10-08 8:08 ` Jiri Pirko
2009-10-08 8:20 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox