Netdev List
 help / color / mirror / Atom feed
From: Vincent Sanders <vince@simtec.co.uk>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] Fix IXP 2000 network driver building.
Date: Mon, 12 Oct 2009 13:45:34 +0100	[thread overview]
Message-ID: <20091012124534.GH28536@kyllikki.org> (raw)
In-Reply-To: <1255349459.2931.7.camel@achroite>

[-- Attachment #1: Type: text/plain, Size: 1005 bytes --]

On Mon, Oct 12, 2009 at 01:10:59PM +0100, Ben Hutchings wrote:
> On Sun, 2009-10-11 at 16:55 +0100, Vincent Sanders wrote:
> > The IXP 2000 network driver was failing to build as it has its own
> > statistics gathering which was not compatible with the recent network
> > device operations changes. This patch fixes the driver in the obvious
> > way and has been compile tested. I have been unable to get the ixp2000
> > maintainer to comment or test this fix.

<snip>

> 
> Is there any reason you can't use dev->stats instead of this private
> field?

I have absolutely no idea ;-) my interest in this is fixing the build
faliure and making the target useful again, unfortunately the
maintainer is MIA, I performed the minimal obvious change. 

I could tidy this futher, but my version of this hardware will not run
the kernel at all (hardware is old broken dev. board) so I am worried
I may break something with a larger blind change.


-- 
Vincent Sanders
Simtec Electronics

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

  reply	other threads:[~2009-10-12 12:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-11 15:55 [PATCH] Fix IXP 2000 network driver building Vincent Sanders
2009-10-12 12:10 ` Ben Hutchings
2009-10-12 12:45   ` Vincent Sanders [this message]
  -- strict thread matches above, loose matches on Subject: below --
2009-10-12 19:46 Vincent Sanders
2009-10-13  7:03 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091012124534.GH28536@kyllikki.org \
    --to=vince@simtec.co.uk \
    --cc=bhutchings@solarflare.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox