* tcp: Try to catch MSG_PEEK bug
@ 2009-10-20 5:41 Herbert Xu
2009-10-20 7:52 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Herbert Xu @ 2009-10-20 5:41 UTC (permalink / raw)
To: David S. Miller, netdev
Hi:
tcp: Try to catch MSG_PEEK bug
This patch tries to print out more information when we hit the
MSG_PEEK bug in tcp_recvmsg. It's been around since at least
2005 and it's about time that we finally fix it.
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Cheer,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
index 64d0af6..fb881d5 100644
--- a/net/ipv4/tcp.c
+++ b/net/ipv4/tcp.c
@@ -1405,7 +1405,9 @@ int tcp_recvmsg(struct kiocb *iocb, struct sock *sk, struct msghdr *msg,
goto found_ok_skb;
if (tcp_hdr(skb)->fin)
goto found_fin_ok;
- WARN_ON(!(flags & MSG_PEEK));
+ if (WARN_ON(!(flags & MSG_PEEK)))
+ printk(KERN_INFO "recvmsg bug 2: copied %X "
+ "seq %X\n", *seq, TCP_SKB_CB(skb)->seq);
}
/* Well, if we have backlog, try to process it now yet. */
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: tcp: Try to catch MSG_PEEK bug
2009-10-20 5:41 tcp: Try to catch MSG_PEEK bug Herbert Xu
@ 2009-10-20 7:52 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-10-20 7:52 UTC (permalink / raw)
To: herbert; +Cc: netdev
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Tue, 20 Oct 2009 14:41:06 +0900
> tcp: Try to catch MSG_PEEK bug
>
> This patch tries to print out more information when we hit the
> MSG_PEEK bug in tcp_recvmsg. It's been around since at least
> 2005 and it's about time that we finally fix it.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Ok, fair enough, I'll stick this into net-2.6 and hopefully
that will help us.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-10-20 7:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-20 5:41 tcp: Try to catch MSG_PEEK bug Herbert Xu
2009-10-20 7:52 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox