Re: [PATCH] s2io: fixing a ethtool test that is broken

[David Miller <davem@davemloft.net>]

From: "Sivakumar Subramani" <Sivakumar.Subramani@neterion.com>
Date: Thu, 12 Nov 2009 13:59:53 -0500

> [Siva] Reviewed the patch. Please accept it.
> 
> Acked-by: Sivakumar Subramani <sivakumar.subramani@neterion.com>

Please use reasonable mechanisms to reply to patches when you review
them.  Something in your mail client software or elsewhere has messed
with the Message-Id and other elements of the email headers, and
therefore the threading of messages so that patchwork and other tools
can attach your reply to the patch posting itself simply do not work.

This makes more work for me and I am not going to go searching for
your replies by hand.

So you should fix this because otherwise your review reply ACKs
will get lost.

Also you have this very non-standard way to attributing your content
by adding these "[Name]" tags.  Please don't do that, it is
non-standard and therefore most people don't understand it at all.

The normal email reply quoting mechanisms of your email client will
let us know exactly what parts are written by you, and what parts are
said by other people in quoted text.

Thank you.