* [PATCH 4/16] drivers/net/ipg.c: remove exceptional & on function name
@ 2009-11-18 18:21 Julia Lawall
2009-11-18 18:49 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Julia Lawall @ 2009-11-18 18:21 UTC (permalink / raw)
To: Francois Romieu, Sorbica Shieh, Jesse Huang, netdev, arnd, joe,
linux-kernel@
From: Julia Lawall <julia@diku.dk>
In this file, function names are otherwise used as pointers without &.
A simplified version of the semantic patch that makes this change is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@r@
identifier f;
@@
f(...) { ... }
@@
identifier r.f;
@@
- &f
+ f
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
drivers/net/ipg.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ipg.c b/drivers/net/ipg.c
index 63056e7..ba8d246 100644
--- a/drivers/net/ipg.c
+++ b/drivers/net/ipg.c
@@ -1751,7 +1751,7 @@ static int ipg_nic_open(struct net_device *dev)
/* Register the interrupt line to be used by the IPG within
* the Linux system.
*/
- rc = request_irq(pdev->irq, &ipg_interrupt_handler, IRQF_SHARED,
+ rc = request_irq(pdev->irq, ipg_interrupt_handler, IRQF_SHARED,
dev->name, dev);
if (rc < 0) {
printk(KERN_INFO "%s: Error when requesting interrupt.\n",
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 4/16] drivers/net/ipg.c: remove exceptional & on function name
2009-11-18 18:21 [PATCH 4/16] drivers/net/ipg.c: remove exceptional & on function name Julia Lawall
@ 2009-11-18 18:49 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-11-18 18:49 UTC (permalink / raw)
To: julia
Cc: romieu, sorbica, jesse, netdev, arnd, joe, linux-kernel,
kernel-janitors
From: Julia Lawall <julia@diku.dk>
Date: Wed, 18 Nov 2009 19:21:45 +0100 (CET)
> In this file, function names are otherwise used as pointers without &.
...
> Signed-off-by: Julia Lawall <julia@diku.dk>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-11-18 18:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-18 18:21 [PATCH 4/16] drivers/net/ipg.c: remove exceptional & on function name Julia Lawall
2009-11-18 18:49 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox