* [net-2.6 PATCH] ixgbe: allow tx of pre-formatted vlan tagged packets
@ 2009-12-15 23:00 Jeff Kirsher
2009-12-16 5:14 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Jeff Kirsher @ 2009-12-15 23:00 UTC (permalink / raw)
To: davem
Cc: netdev, gospo, Gurucharan Shetty, Arthur Jones,
Mallikarjuna R Chilakala, Jeff Kirsher
From: Gurucharan Shetty <gshetty@riverbed.com>
When the 82598 is fed 802.1q packets, it chokes with
an error of the form:
ixgbe: eth0: ixgbe_tx_csum: partial checksum but proto=81!
As the logic there was not smart enough to look into
the vlan header to pick out the encapsulated protocol.
There are times when we'd like to send these packets
out without having to configure a vlan on the interface.
Here we check for the vlan tag and allow the packet to
go out with the correct hardware checksum.
This patch is a clone of a previously submitted patch by
Arthur Jones <ajones@riverbed.com> for igb (Commit -
fa4a7ef36ec834fee1719636b30d2f28f4cb0166).
Signed-off-by: Gurucharan Shetty <gshetty@riverbed.com>
Signed-off-by: Arthur Jones <ajones@riverbed.com>
Acked-by: Mallikarjuna R Chilakala <mallikarjuna.chilakala@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
drivers/net/ixgbe/ixgbe_main.c | 13 ++++++++++++-
1 files changed, 12 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c
index 22519fa..47c55d2 100644
--- a/drivers/net/ixgbe/ixgbe_main.c
+++ b/drivers/net/ixgbe/ixgbe_main.c
@@ -5006,7 +5006,18 @@ static bool ixgbe_tx_csum(struct ixgbe_adapter *adapter,
IXGBE_ADVTXD_DTYP_CTXT);
if (skb->ip_summed == CHECKSUM_PARTIAL) {
- switch (skb->protocol) {
+ __be16 protocol;
+
+ if (skb->protocol == cpu_to_be16(ETH_P_8021Q)) {
+ const struct vlan_ethhdr *vhdr =
+ (const struct vlan_ethhdr *)skb->data;
+
+ protocol = vhdr->h_vlan_encapsulated_proto;
+ } else {
+ protocol = skb->protocol;
+ }
+
+ switch (protocol) {
case cpu_to_be16(ETH_P_IP):
type_tucmd_mlhl |= IXGBE_ADVTXD_TUCMD_IPV4;
if (ip_hdr(skb)->protocol == IPPROTO_TCP)
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [net-2.6 PATCH] ixgbe: allow tx of pre-formatted vlan tagged packets
2009-12-15 23:00 [net-2.6 PATCH] ixgbe: allow tx of pre-formatted vlan tagged packets Jeff Kirsher
@ 2009-12-16 5:14 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-12-16 5:14 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, gospo, gshetty, ajones, mallikarjuna.chilakala
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Tue, 15 Dec 2009 15:00:31 -0800
> From: Gurucharan Shetty <gshetty@riverbed.com>
>
> When the 82598 is fed 802.1q packets, it chokes with
> an error of the form:
>
> ixgbe: eth0: ixgbe_tx_csum: partial checksum but proto=81!
...
> Signed-off-by: Gurucharan Shetty <gshetty@riverbed.com>
> Signed-off-by: Arthur Jones <ajones@riverbed.com>
> Acked-by: Mallikarjuna R Chilakala <mallikarjuna.chilakala@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-12-16 5:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-15 23:00 [net-2.6 PATCH] ixgbe: allow tx of pre-formatted vlan tagged packets Jeff Kirsher
2009-12-16 5:14 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox