* [PATCH] allow nf_tproxy_core module to unload
@ 2009-12-18 16:24 Evan McNabb
2009-12-19 3:41 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Evan McNabb @ 2009-12-18 16:24 UTC (permalink / raw)
To: netdev; +Cc: Evan McNabb, sassmann
From: Evan McNabb <emcnabb@redhat.com>
Include exit function so nf_tproxy_core module can be removed.
Signed-off-by: Evan McNabb <emcnabb@redhat.com>
diff --git a/net/netfilter/nf_tproxy_core.c b/net/netfilter/nf_tproxy_core.c
index 5490fc3..ec6737c 100644
--- a/net/netfilter/nf_tproxy_core.c
+++ b/net/netfilter/nf_tproxy_core.c
@@ -89,7 +89,12 @@ static int __init nf_tproxy_init(void)
return 0;
}
+static void __exit nf_tproxy_exit(void)
+{
+}
+
module_init(nf_tproxy_init);
+module_exit(nf_tproxy_exit);
MODULE_LICENSE("GPL");
MODULE_AUTHOR("Krisztian Kovacs");
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] allow nf_tproxy_core module to unload
2009-12-18 16:24 [PATCH] allow nf_tproxy_core module to unload Evan McNabb
@ 2009-12-19 3:41 ` David Miller
2009-12-21 7:12 ` KOVACS Krisztian
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2009-12-19 3:41 UTC (permalink / raw)
To: emcnabb; +Cc: netdev, sassmann, netfilter-devel
From: Evan McNabb <emcnabb@redhat.com>
Date: Fri, 18 Dec 2009 11:24:40 -0500
> From: Evan McNabb <emcnabb@redhat.com>
>
> Include exit function so nf_tproxy_core module can be removed.
>
> Signed-off-by: Evan McNabb <emcnabb@redhat.com>
netfilter-devel is the best place to CC: netfilter
patches, added...
>
> diff --git a/net/netfilter/nf_tproxy_core.c b/net/netfilter/nf_tproxy_core.c
> index 5490fc3..ec6737c 100644
> --- a/net/netfilter/nf_tproxy_core.c
> +++ b/net/netfilter/nf_tproxy_core.c
> @@ -89,7 +89,12 @@ static int __init nf_tproxy_init(void)
> return 0;
> }
>
> +static void __exit nf_tproxy_exit(void)
> +{
> +}
> +
> module_init(nf_tproxy_init);
> +module_exit(nf_tproxy_exit);
>
> MODULE_LICENSE("GPL");
> MODULE_AUTHOR("Krisztian Kovacs");
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] allow nf_tproxy_core module to unload
2009-12-19 3:41 ` David Miller
@ 2009-12-21 7:12 ` KOVACS Krisztian
0 siblings, 0 replies; 3+ messages in thread
From: KOVACS Krisztian @ 2009-12-21 7:12 UTC (permalink / raw)
To: emcnabb; +Cc: DavidMiller, netdev, sassmann, netfilter-devel
Hi,
On Fri, 2009-12-18 at 19:41 -0800, David Miller wrote:
> From: Evan McNabb <emcnabb@redhat.com>
> Date: Fri, 18 Dec 2009 11:24:40 -0500
>
> > From: Evan McNabb <emcnabb@redhat.com>
> >
> > Include exit function so nf_tproxy_core module can be removed.
> >
> > Signed-off-by: Evan McNabb <emcnabb@redhat.com>
>
> netfilter-devel is the best place to CC: netfilter
> patches, added...
>
> >
> > diff --git a/net/netfilter/nf_tproxy_core.c b/net/netfilter/nf_tproxy_core.c
> > index 5490fc3..ec6737c 100644
> > --- a/net/netfilter/nf_tproxy_core.c
> > +++ b/net/netfilter/nf_tproxy_core.c
> > @@ -89,7 +89,12 @@ static int __init nf_tproxy_init(void)
> > return 0;
> > }
> >
> > +static void __exit nf_tproxy_exit(void)
> > +{
> > +}
> > +
> > module_init(nf_tproxy_init);
> > +module_exit(nf_tproxy_exit);
> >
> > MODULE_LICENSE("GPL");
> > MODULE_AUTHOR("Krisztian Kovacs");
I'm afraid it's not that simple...
tproxy sets skb->destructor to nf_tproxy_destructor for certain
(redirected) skbs. You must make sure that no skbs have their destructor
set to that function before removing the module.
Cheers,
Krisztian
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-12-21 7:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-18 16:24 [PATCH] allow nf_tproxy_core module to unload Evan McNabb
2009-12-19 3:41 ` David Miller
2009-12-21 7:12 ` KOVACS Krisztian
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox