From: David Miller <davem@davemloft.net>
To: ajitk@serverengines.com, ajitkhaparde@gmail.com
Cc: wzt.wzt@gmail.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, linux-drivers@serverengines.com,
sathyap@serverengines.com
Subject: Re: [PATCH] benet: Fix compile warnnings in drivers/net/benet/be_ethtool.c
Date: Sat, 27 Mar 2010 08:32:19 -0700 (PDT) [thread overview]
Message-ID: <20100327.083219.104064186.davem@davemloft.net> (raw)
In-Reply-To: <20100326171616.GA20879@serverengines.com>
From: Ajit Khaparde <ajitkhaparde@gmail.com>
Date: Fri, 26 Mar 2010 22:46:18 +0530
> On 26/03/10 14:12 +0800, wzt.wzt@gmail.com wrote:
>> Fix the following warnings:
>>
>> be_ethtool.c:493: warning: integer constant is too large for 'long' type
>> be_ethtool.c:493: warning: integer constant is too large for 'long' type
>>
>> Signed-off-by: Zhitong Wang <zhitong.wangzt@alibaba-inc.com>
>
> I would suggest using be2net instead of benet during the commit.
> be2net: Fix compile warnnings in drivers/net/benet/be_ethtool.c
>
> Acked-by: Ajit Khaparde <ajitk@serverengines.com>
Well, you cannot be surprised that people will use "benet"
since that is the name of the directory the driver lives
under. It is not even referred to as "be2net" in the
MAINTAINERS entry.
I'm applying this fix as-is.
prev parent reply other threads:[~2010-03-27 15:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-26 6:12 [PATCH] benet: Fix compile warnnings in drivers/net/benet/be_ethtool.c wzt.wzt
2010-03-26 17:16 ` Ajit Khaparde
2010-03-27 15:32 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100327.083219.104064186.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ajitk@serverengines.com \
--cc=ajitkhaparde@gmail.com \
--cc=linux-drivers@serverengines.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sathyap@serverengines.com \
--cc=wzt.wzt@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox