* [PATCH] benet: Fix compile warnnings in drivers/net/benet/be_ethtool.c
@ 2010-03-26 6:12 wzt.wzt
2010-03-26 17:16 ` Ajit Khaparde
0 siblings, 1 reply; 3+ messages in thread
From: wzt.wzt @ 2010-03-26 6:12 UTC (permalink / raw)
To: linux-kernel; +Cc: netdev, linux-drivers, sathyap
Fix the following warnings:
be_ethtool.c:493: warning: integer constant is too large for 'long' type
be_ethtool.c:493: warning: integer constant is too large for 'long' type
Signed-off-by: Zhitong Wang <zhitong.wangzt@alibaba-inc.com>
---
drivers/net/benet/be_ethtool.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/benet/be_ethtool.c b/drivers/net/benet/be_ethtool.c
index 9560d48..51e1065 100644
--- a/drivers/net/benet/be_ethtool.c
+++ b/drivers/net/benet/be_ethtool.c
@@ -490,7 +490,7 @@ be_test_ddr_dma(struct be_adapter *adapter)
{
int ret, i;
struct be_dma_mem ddrdma_cmd;
- u64 pattern[2] = {0x5a5a5a5a5a5a5a5a, 0xa5a5a5a5a5a5a5a5};
+ u64 pattern[2] = {0x5a5a5a5a5a5a5a5aULL, 0xa5a5a5a5a5a5a5a5ULL};
ddrdma_cmd.size = sizeof(struct be_cmd_req_ddrdma_test);
ddrdma_cmd.va = pci_alloc_consistent(adapter->pdev, ddrdma_cmd.size,
--
1.6.5.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] benet: Fix compile warnnings in drivers/net/benet/be_ethtool.c
2010-03-26 6:12 [PATCH] benet: Fix compile warnnings in drivers/net/benet/be_ethtool.c wzt.wzt
@ 2010-03-26 17:16 ` Ajit Khaparde
2010-03-27 15:32 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Ajit Khaparde @ 2010-03-26 17:16 UTC (permalink / raw)
To: wzt.wzt; +Cc: linux-kernel, netdev, linux-drivers, sathyap
On 26/03/10 14:12 +0800, wzt.wzt@gmail.com wrote:
> Fix the following warnings:
>
> be_ethtool.c:493: warning: integer constant is too large for 'long' type
> be_ethtool.c:493: warning: integer constant is too large for 'long' type
>
> Signed-off-by: Zhitong Wang <zhitong.wangzt@alibaba-inc.com>
I would suggest using be2net instead of benet during the commit.
be2net: Fix compile warnnings in drivers/net/benet/be_ethtool.c
Acked-by: Ajit Khaparde <ajitk@serverengines.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] benet: Fix compile warnnings in drivers/net/benet/be_ethtool.c
2010-03-26 17:16 ` Ajit Khaparde
@ 2010-03-27 15:32 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2010-03-27 15:32 UTC (permalink / raw)
To: ajitk, ajitkhaparde; +Cc: wzt.wzt, linux-kernel, netdev, linux-drivers, sathyap
From: Ajit Khaparde <ajitkhaparde@gmail.com>
Date: Fri, 26 Mar 2010 22:46:18 +0530
> On 26/03/10 14:12 +0800, wzt.wzt@gmail.com wrote:
>> Fix the following warnings:
>>
>> be_ethtool.c:493: warning: integer constant is too large for 'long' type
>> be_ethtool.c:493: warning: integer constant is too large for 'long' type
>>
>> Signed-off-by: Zhitong Wang <zhitong.wangzt@alibaba-inc.com>
>
> I would suggest using be2net instead of benet during the commit.
> be2net: Fix compile warnnings in drivers/net/benet/be_ethtool.c
>
> Acked-by: Ajit Khaparde <ajitk@serverengines.com>
Well, you cannot be surprised that people will use "benet"
since that is the name of the directory the driver lives
under. It is not even referred to as "be2net" in the
MAINTAINERS entry.
I'm applying this fix as-is.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-03-27 15:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-26 6:12 [PATCH] benet: Fix compile warnnings in drivers/net/benet/be_ethtool.c wzt.wzt
2010-03-26 17:16 ` Ajit Khaparde
2010-03-27 15:32 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox