From: David Miller <davem@davemloft.net>
To: akpm@linux-foundation.org
Cc: netdev@vger.kernel.org, dan.j.rosenberg@gmail.com,
grundler@parisc-linux.org, jeffm@suse.com
Subject: Re: [patch 1/2] drivers-net-tulip-de4x5c-fix-copy-length-in-de4x5_ioctl-checkpatch-fixes
Date: Sun, 03 Oct 2010 22:00:43 -0700 (PDT) [thread overview]
Message-ID: <20101003.220043.39188941.davem@davemloft.net> (raw)
In-Reply-To: <201010012117.o91LHCJt021158@imap1.linux-foundation.org>
From: akpm@linux-foundation.org
Date: Fri, 01 Oct 2010 14:17:12 -0700
> From: Andrew Morton <akpm@linux-foundation.org>
>
> ERROR: trailing statements should be on next line
> #23: FILE: drivers/net/tulip/de4x5.c:5477:
> + if (copy_to_user(ioc->data, tmp.lval, ioc->len)) return -EFAULT;
>
> total: 1 errors, 0 warnings, 8 lines checked
>
> ./patches/drivers-net-tulip-de4x5c-fix-copy-length-in-de4x5_ioctl.patch has style problems, please review. If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
>
> Please run checkpatch prior to sending patches
>
> Cc: Dan Rosenberg <dan.j.rosenberg@gmail.com>
> Cc: Grant Grundler <grundler@parisc-linux.org>
> Cc: Jeff Mahoney <jeffm@suse.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Applied to net-next-2.6
prev parent reply other threads:[~2010-10-04 5:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-01 21:17 [patch 1/2] drivers-net-tulip-de4x5c-fix-copy-length-in-de4x5_ioctl-checkpatch-fixes akpm
2010-10-04 5:00 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101003.220043.39188941.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=dan.j.rosenberg@gmail.com \
--cc=grundler@parisc-linux.org \
--cc=jeffm@suse.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox