* [patch 1/2] drivers-net-tulip-de4x5c-fix-copy-length-in-de4x5_ioctl-checkpatch-fixes
@ 2010-10-01 21:17 akpm
2010-10-04 5:00 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: akpm @ 2010-10-01 21:17 UTC (permalink / raw)
To: davem; +Cc: netdev, akpm, dan.j.rosenberg, grundler, jeffm
From: Andrew Morton <akpm@linux-foundation.org>
ERROR: trailing statements should be on next line
#23: FILE: drivers/net/tulip/de4x5.c:5477:
+ if (copy_to_user(ioc->data, tmp.lval, ioc->len)) return -EFAULT;
total: 1 errors, 0 warnings, 8 lines checked
./patches/drivers-net-tulip-de4x5c-fix-copy-length-in-de4x5_ioctl.patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Please run checkpatch prior to sending patches
Cc: Dan Rosenberg <dan.j.rosenberg@gmail.com>
Cc: Grant Grundler <grundler@parisc-linux.org>
Cc: Jeff Mahoney <jeffm@suse.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
drivers/net/tulip/de4x5.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff -puN drivers/net/tulip/de4x5.c~drivers-net-tulip-de4x5c-fix-copy-length-in-de4x5_ioctl-checkpatch-fixes drivers/net/tulip/de4x5.c
--- a/drivers/net/tulip/de4x5.c~drivers-net-tulip-de4x5c-fix-copy-length-in-de4x5_ioctl-checkpatch-fixes
+++ a/drivers/net/tulip/de4x5.c
@@ -5474,7 +5474,8 @@ de4x5_ioctl(struct net_device *dev, stru
tmp.lval[6] = inl(DE4X5_STRR); j+=4;
tmp.lval[7] = inl(DE4X5_SIGR); j+=4;
ioc->len = j;
- if (copy_to_user(ioc->data, tmp.lval, ioc->len)) return -EFAULT;
+ if (copy_to_user(ioc->data, tmp.lval, ioc->len))
+ return -EFAULT;
break;
#define DE4X5_DUMP 0x0f /* Dump the DE4X5 Status */
_
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch 1/2] drivers-net-tulip-de4x5c-fix-copy-length-in-de4x5_ioctl-checkpatch-fixes
2010-10-01 21:17 [patch 1/2] drivers-net-tulip-de4x5c-fix-copy-length-in-de4x5_ioctl-checkpatch-fixes akpm
@ 2010-10-04 5:00 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-10-04 5:00 UTC (permalink / raw)
To: akpm; +Cc: netdev, dan.j.rosenberg, grundler, jeffm
From: akpm@linux-foundation.org
Date: Fri, 01 Oct 2010 14:17:12 -0700
> From: Andrew Morton <akpm@linux-foundation.org>
>
> ERROR: trailing statements should be on next line
> #23: FILE: drivers/net/tulip/de4x5.c:5477:
> + if (copy_to_user(ioc->data, tmp.lval, ioc->len)) return -EFAULT;
>
> total: 1 errors, 0 warnings, 8 lines checked
>
> ./patches/drivers-net-tulip-de4x5c-fix-copy-length-in-de4x5_ioctl.patch has style problems, please review. If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
>
> Please run checkpatch prior to sending patches
>
> Cc: Dan Rosenberg <dan.j.rosenberg@gmail.com>
> Cc: Grant Grundler <grundler@parisc-linux.org>
> Cc: Jeff Mahoney <jeffm@suse.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Applied to net-next-2.6
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-10-04 5:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-01 21:17 [patch 1/2] drivers-net-tulip-de4x5c-fix-copy-length-in-de4x5_ioctl-checkpatch-fixes akpm
2010-10-04 5:00 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox