* [PATCH] staging: get rid of dev_base_lock
@ 2010-10-29 13:19 Eric Dumazet
2010-10-29 13:47 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Eric Dumazet @ 2010-10-29 13:19 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: netdev, David Miller
dev_base_lock was the legacy rwlock used to protect netdevice list, and
is expected to vanish.
We now use RTNL and RCU locking.
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
---
drivers/staging/wlags49_h2/wl_sysfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wlags49_h2/wl_sysfs.c b/drivers/staging/wlags49_h2/wl_sysfs.c
index e4c8804..9b833b3 100644
--- a/drivers/staging/wlags49_h2/wl_sysfs.c
+++ b/drivers/staging/wlags49_h2/wl_sysfs.c
@@ -42,7 +42,7 @@ static ssize_t show_tallies(struct device *d, struct device_attribute *attr,
CFG_HERMES_TALLIES_STRCT tallies;
ssize_t ret = -EINVAL;
- read_lock(&dev_base_lock);
+ rcu_read_lock();
if (dev_isalive(dev)) {
wl_lock(lp, &flags);
@@ -102,7 +102,7 @@ static ssize_t show_tallies(struct device *d, struct device_attribute *attr,
}
}
- read_unlock(&dev_base_lock);
+ rcu_read_unlock();
return ret;
}
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: get rid of dev_base_lock
2010-10-29 13:19 [PATCH] staging: get rid of dev_base_lock Eric Dumazet
@ 2010-10-29 13:47 ` Greg KH
2010-10-29 13:49 ` Eric Dumazet
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2010-10-29 13:47 UTC (permalink / raw)
To: Eric Dumazet; +Cc: netdev, David Miller
On Fri, Oct 29, 2010 at 03:19:27PM +0200, Eric Dumazet wrote:
> dev_base_lock was the legacy rwlock used to protect netdevice list, and
> is expected to vanish.
>
> We now use RTNL and RCU locking.
Is this a .38 patch, or something that needs to be in .37?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: get rid of dev_base_lock
2010-10-29 13:47 ` Greg KH
@ 2010-10-29 13:49 ` Eric Dumazet
0 siblings, 0 replies; 3+ messages in thread
From: Eric Dumazet @ 2010-10-29 13:49 UTC (permalink / raw)
To: Greg KH; +Cc: netdev, David Miller
Le vendredi 29 octobre 2010 à 06:47 -0700, Greg KH a écrit :
> On Fri, Oct 29, 2010 at 03:19:27PM +0200, Eric Dumazet wrote:
> > dev_base_lock was the legacy rwlock used to protect netdevice list, and
> > is expected to vanish.
> >
> > We now use RTNL and RCU locking.
>
> Is this a .38 patch, or something that needs to be in .37?
>
> thanks,
>
> greg k-h
Its a .38 patch, no hurry ;)
Thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-10-29 13:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-29 13:19 [PATCH] staging: get rid of dev_base_lock Eric Dumazet
2010-10-29 13:47 ` Greg KH
2010-10-29 13:49 ` Eric Dumazet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox