From: Stephen Hemminger <shemminger@vyatta.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Changli Gao <xiaosuo@gmail.com>,
David Miller <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH 3/3] ipip: add module alias for tunl0 tunnel device
Date: Tue, 30 Nov 2010 08:08:42 -0800 [thread overview]
Message-ID: <20101130080842.685e0b70@nehalam> (raw)
In-Reply-To: <1291105269.2725.52.camel@edumazet-laptop>
On Tue, 30 Nov 2010 09:21:09 +0100
Eric Dumazet <eric.dumazet@gmail.com> wrote:
> Le mardi 30 novembre 2010 à 15:55 +0800, Changli Gao a écrit :
> > On Tue, Nov 30, 2010 at 3:19 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
> > > Le lundi 29 novembre 2010 à 11:47 -0800, Stephen Hemminger a écrit :
> > >> pièce jointe document texte brut (ipip-alias.patch)
> > >> If ipip is built as a module the 'ip tunnel add' command would fail because
> > >> the ipip module was not being autoloaded. Adding an alias for
> > >> the tunl0 device name cause dev_load() to autoload it when needed.
> > >>
> > >> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
> > >>
> > >> --- a/net/ipv4/ipip.c 2010-11-29 11:40:25.026277890 -0800
> > >> +++ b/net/ipv4/ipip.c 2010-11-29 11:41:05.790681069 -0800
> > >> @@ -913,3 +913,4 @@ static void __exit ipip_fini(void)
> > >> module_init(ipip_init);
> > >> module_exit(ipip_fini);
> > >> MODULE_LICENSE("GPL");
> > >> +MODULE_ALIAS("tunl0");
> > >
> > > I am not sure I understand you...
> > >
> > > Here, I do have ipip built as a module, and I have no problem :
> > >
> > > # lsmod|grep ipip
> > > # ip tunnel add
> > > cannot determine tunnel mode (ipip, gre or sit)
> > > # lsmod|grep ipip
> > > # ip tunnel add mode ipip
> > > # lsmod|grep ipip
> > > ipip 7692 0
> > > tunnel4 2949 1 ipip
> > > #
> > >
> > > What am I missing ?
> > >
> > >
> >
> > localhost linux # lsmod
> > Module Size Used by
> > ipv6 309359 12
> > localhost linux # ip -V
> > ip utility, iproute2-ss091226
> > localhost linux # ip tunnel add mode gre
> > ioctl: No such device
> > localhost linux # ip tunnel add mode ipip
> > ioctl: No such device
> > localhost linux # modprobe ip_gre
> > localhost linux # modprobe ipip
> > localhost linux # ip tunnel add mode ipip
> > localhost linux # ip tunnel add mode gre
> > localhost linux # lsmod
> > Module Size Used by
> > ipip 8128 0
> > tunnel4 2683 1 ipip
> > ip_gre 15055 0
> > gre 1967 1 ip_gre
> > ipv6 309359 13 ip_gre
> >
> >
>
> Hmm. I still dont get it, ipv6 as a module ?
>
> Works well here.
>
> # lsmod
> Module Size Used by
> bonding 89194 0
> ipv6 232889 29 bonding
> # ip tunnel add mode ipip
> # lsmod
> Module Size Used by
> ipip 6221 0
> bonding 89194 0
> ipv6 232889 29 bonding
> # ip -V
> ip utility, iproute2-ss100823
> #
If you run debian there is a list of aliases in /etc/modprobe.d/aliases.conf
that includes the ipip alias.
My patch provides same information from the kernel. In olden times,
the kernel relied more on user space defined aliases, but in the modern
era MODULE_ALIAS() is used to provide that information.
next prev parent reply other threads:[~2010-11-30 16:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-29 19:47 [PATCH 0/3] Tunneling minor patches Stephen Hemminger
2010-11-29 19:47 ` [PATCH 1/3] gre: minor cleanups Stephen Hemminger
2010-11-29 19:47 ` [PATCH 2/3] gre: add module alias for gre0 tunnel device Stephen Hemminger
2010-11-29 19:47 ` [PATCH 3/3] ipip: add module alias for tunl0 " Stephen Hemminger
2010-11-30 7:19 ` Eric Dumazet
2010-11-30 7:55 ` Changli Gao
2010-11-30 8:21 ` Eric Dumazet
2010-11-30 16:08 ` Stephen Hemminger [this message]
2010-11-30 16:27 ` Eric Dumazet
2010-12-01 20:52 ` [PATCH 0/3] Tunneling minor patches David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101130080842.685e0b70@nehalam \
--to=shemminger@vyatta.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox