* PATCH: fix hang in dmfe driver on sending of big packet (linux-2.6.35)
@ 2010-11-30 13:38 Alexander V. Lukyanov
0 siblings, 0 replies; only message in thread
From: Alexander V. Lukyanov @ 2010-11-30 13:38 UTC (permalink / raw)
To: netdev, tori
[-- Attachment #1: Type: text/plain, Size: 170 bytes --]
Hello!
This patch fixes hang in dmfe driver on attempt of sending a big packet.
Without this patch the code stops the queue and never wakes it again.
--
Alexander.
[-- Attachment #2: dmfe.patch --]
[-- Type: text/plain, Size: 602 bytes --]
--- dmfe.c.1 2010-11-30 16:21:52.758465207 +0300
+++ dmfe.c 2010-11-30 16:24:45.301468601 +0300
@@ -687,18 +687,18 @@
unsigned long flags;
DMFE_DBUG(0, "dmfe_start_xmit", 0);
- /* Resource flag check */
- netif_stop_queue(dev);
-
/* Too large packet check */
if (skb->len > MAX_PACKET_SIZE) {
pr_err("big packet = %d\n", (u16)skb->len);
dev_kfree_skb(skb);
return NETDEV_TX_OK;
}
+ /* Resource flag check */
+ netif_stop_queue(dev);
+
spin_lock_irqsave(&db->lock, flags);
/* No Tx resource check, it never happen nromally */
if (db->tx_queue_cnt >= TX_FREE_DESC_CNT) {
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2010-11-30 14:21 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-30 13:38 PATCH: fix hang in dmfe driver on sending of big packet (linux-2.6.35) Alexander V. Lukyanov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox