Netdev List
 help / color / mirror / Atom feed
From: Jiri Pirko <jpirko@redhat.com>
To: robert.w.love@intel.com
Cc: netdev@vger.kernel.org
Subject: [question] fcoe: bonding support
Date: Mon, 28 Feb 2011 13:29:58 +0100	[thread overview]
Message-ID: <20110228122957.GB4043@psychotron.brq.redhat.com> (raw)

Hi Robert.

I wonder what's the meaning of the following code in fcoe_interface_setup():

        /* Do not support for bonding device */
        if ((netdev->priv_flags & IFF_MASTER_ALB) ||
            (netdev->priv_flags & IFF_SLAVE_INACTIVE) ||
            (netdev->priv_flags & IFF_MASTER_8023AD)) {
                FCOE_NETDEV_DBG(netdev, "Bonded interfaces not supported\n");
                return -EOPNOTSUPP;
        }

>From this I cannot understand if bonding is not supported at all or
only alb and 8023ad modes are not supported (leaving aside completely
bogus checking for IFF_SLAVE_INACTIVE).

How about to check IFF_BONDING only (in case bonding should not be
supported at all)

Thanks.

Jirka

             reply	other threads:[~2011-02-28 12:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-28 12:29 Jiri Pirko [this message]
2011-03-02  0:05 ` [question] fcoe: bonding support Robert Love

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110228122957.GB4043@psychotron.brq.redhat.com \
    --to=jpirko@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=robert.w.love@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox