From: Robert Love <robert.w.love@intel.com>
To: Jiri Pirko <jpirko@redhat.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [question] fcoe: bonding support
Date: Tue, 01 Mar 2011 16:05:11 -0800 [thread overview]
Message-ID: <1299024311.24189.88.camel@fritz> (raw)
In-Reply-To: <20110228122957.GB4043@psychotron.brq.redhat.com>
On Mon, 2011-02-28 at 04:29 -0800, Jiri Pirko wrote:
> Hi Robert.
>
Hi Jirka,
I think the other community members have probably answered your
questions sufficiently, but since you addressed me directly I figured I
should reply. Let me know if you need any further assistance. I'll also
be happy to pick up your patch when it's done.
//Rob
> I wonder what's the meaning of the following code in fcoe_interface_setup():
>
> /* Do not support for bonding device */
> if ((netdev->priv_flags & IFF_MASTER_ALB) ||
> (netdev->priv_flags & IFF_SLAVE_INACTIVE) ||
> (netdev->priv_flags & IFF_MASTER_8023AD)) {
> FCOE_NETDEV_DBG(netdev, "Bonded interfaces not supported\n");
> return -EOPNOTSUPP;
> }
>
> From this I cannot understand if bonding is not supported at all or
> only alb and 8023ad modes are not supported (leaving aside completely
> bogus checking for IFF_SLAVE_INACTIVE).
>
> How about to check IFF_BONDING only (in case bonding should not be
> supported at all)
>
> Thanks.
>
> Jirka
prev parent reply other threads:[~2011-03-02 0:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-28 12:29 [question] fcoe: bonding support Jiri Pirko
2011-03-02 0:05 ` Robert Love [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1299024311.24189.88.camel@fritz \
--to=robert.w.love@intel.com \
--cc=jpirko@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox