[question] fcoe: bonding support

[question] fcoe: bonding support

[Jiri Pirko]

Hi Robert.

I wonder what's the meaning of the following code in fcoe_interface_setup():

        /* Do not support for bonding device */
        if ((netdev->priv_flags & IFF_MASTER_ALB) ||
            (netdev->priv_flags & IFF_SLAVE_INACTIVE) ||
            (netdev->priv_flags & IFF_MASTER_8023AD)) {
                FCOE_NETDEV_DBG(netdev, "Bonded interfaces not supported\n");
                return -EOPNOTSUPP;
        }

>From this I cannot understand if bonding is not supported at all or
only alb and 8023ad modes are not supported (leaving aside completely
bogus checking for IFF_SLAVE_INACTIVE).

How about to check IFF_BONDING only (in case bonding should not be
supported at all)

Thanks.

Jirka

Re: [question] fcoe: bonding support

[Robert Love]

On Mon, 2011-02-28 at 04:29 -0800, Jiri Pirko wrote:
> Hi Robert.
> 
Hi Jirka,

   I think the other community members have probably answered your
questions sufficiently, but since you addressed me directly I figured I
should reply. Let me know if you need any further assistance. I'll also
be happy to pick up your patch when it's done.

//Rob

> I wonder what's the meaning of the following code in fcoe_interface_setup():
> 
>         /* Do not support for bonding device */
>         if ((netdev->priv_flags & IFF_MASTER_ALB) ||
>             (netdev->priv_flags & IFF_SLAVE_INACTIVE) ||
>             (netdev->priv_flags & IFF_MASTER_8023AD)) {
>                 FCOE_NETDEV_DBG(netdev, "Bonded interfaces not supported\n");
>                 return -EOPNOTSUPP;
>         }
> 
> From this I cannot understand if bonding is not supported at all or
> only alb and 8023ad modes are not supported (leaving aside completely
> bogus checking for IFF_SLAVE_INACTIVE).
> 
> How about to check IFF_BONDING only (in case bonding should not be
> supported at all)
> 
> Thanks.
> 
> Jirka